Closed
Bug 826180
Opened 12 years ago
Closed 12 years ago
No stylesheets shown after reloading a page with an iframe
Categories
(DevTools :: Style Editor, defect, P1)
DevTools
Style Editor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: harth, Assigned: harth)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
STR:
1) visit http://google.com
2) Open Style Editor
3) Observe long list of stylesheets
4) Reload page
Expected:
Stylesheets re-appear in Style Editor after reload
Actual:
Empty Style Editor with "This page has no stylesheet" after reload
I have a fix.
|
Assignee | |
Comment 1•12 years ago
|
||
The style editor resets when it receives a "will-navigate" event. That event was being fired when any iframe in the page navigated.
This patch adds a check to make sure the navigate event is fired only when the root page navigates.
Assignee: nobody → fayearthur
Attachment #697372 -
Flags: review?(jwalker)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 697372 [details] [diff] [review]
Don't emit "navigate" event from target if child frame is navigating
Could you compare the windows instead of the URL?
Attachment #697372 -
Flags: review?(jwalker)
|
|
Assignee | |
Comment 3•12 years ago
|
||
This one is better, compares window objects instead of urls.
Attachment #697372 -
Attachment is obsolete: true
Attachment #697380 -
Flags: review?(jwalker)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Just realized that, thanks Paul
|
|
||
Updated•12 years ago
|
Attachment #697380 -
Flags: review?(jwalker) → review+
|
|
||
Updated•12 years ago
|
Priority: -- → P1
|
|
||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
|
||
Comment 5•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•