Closed Bug 826286 Opened 12 years ago Closed 12 years ago

Selecting a timezone in the Date & Time screen in FTE always displays an incorrect time - should display the time respective of the timezone

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
RESOLVED FIXED
Milestone:
B2G C4 (2jan on)
Project Flags:
blocking-basecamp +

People

(Reporter: jsmith, Assigned: timdream)

Details

Attachments

(1 file)

Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332
(deleted), text/plain
kaze
: review+
Details 
In the date & time screen in the FTE:

If a user selects a timezone in the date & time screen, the time shown in the last selection box is wrong. We should display the time respective of the user's timezone.
This one may be worth re-sending into triage - it's annoying in setup, 100% reproducible, and embarrassing.
blocking-basecamp: --- → ?
Assignee: nobody → kaze
blocking-basecamp: ? → +
Priority: -- → P3
Target Milestone: --- → B2G C4 (2jan on)
Once we click into the time, the time corrects itself.
FYI: the build script also has an issue with setting the time.  I mentioned this in bug 806467.
Stealing, since Naoki told me this bug about is a fairly simple UI out-of-sync issue.
Assignee: kaze → timdream+bugs
Comment on attachment 698711 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332

remove the review flag -- I should patch tz_select.js instead.
Attachment #698711 - Flags: review?(kaze)
Comment on attachment 698711 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332

https://github.com/mozilla-b2g/gaia/pull/7331
https://github.com/mozilla-b2g/gaia/pull/7332

I am not sure what's reviewer's preference on this, so I decided to submit both of them. Kaze, could your r+ either of them? Thanks.
Attachment #698711 - Attachment description: Github: https://github.com/mozilla-b2g/gaia/pull/7331 → Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332
Attachment #698711 - Flags: review?(kaze)
Comment on attachment 698711 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332

fernando should be able to review this too :)
Attachment #698711 - Flags: review?(fernando.campo)
(In reply to Fabien Cazenave [:kaze] from comment #9)
> Comment on attachment 698711 [details]
> Github: https://github.com/mozilla-b2g/gaia/pull/7331 or
> https://github.com/mozilla-b2g/gaia/pull/7332
> 
> looks good, thanks!

Are you talking about 7331 or 7332 here?
Flags: needinfo?(kaze)
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #10)
> Are you talking about 7331 or 7332 here?

I’ve just merged 7332.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #698711 - Flags: review?(fernando.campo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: