Michael Kraft [:morac] Assignee
	Description • 12 years ago

The JavaScript Debugger Add-on (aka Venkman) does not load in the current nightly load (20.0a1 (2013-01-03)).  It puts up the following error:

An exception occurred while initializing, please file a bug.
ReferenceError: initViews is not defined @ <chrome://venkman/content/venkman-static.js> 614


I'm not sure when it broke exactly, but it was relatively recently.

	Michael Kraft [:morac] Assignee
	Comment 1 • 12 years ago

I checked the error console and there's an error in file that defines initView():

Timestamp: 1/3/2013 1:04:30 PM
Error: SyntaxError: missing ( after for
Source File: chrome://venkman/content/venkman-views.js
Line: 3590, Column: 16
Source Code:
            for each (node in fragment.childNodes) 


It looks like "for each" has been removed from the latest Nightly.  See bug 825801.

	Michael Kraft [:morac] Assignee
	Comment 2 • 12 years ago

Not sure if this is being maintained anymore so I threw together a patch and used the reviewer of the last patch.

	Hartmut Figge
	Comment 3 • 12 years ago

WFM for SM Trunk Linux x86-64. I had to change a/resources manually to
a/mozilla/extensions/venkman/resources so that the patch was compatible with my build system.

	:Gijs (he/him)
	Comment 4 • 12 years ago

Comment on attachment 697535 [details] [diff] [review]
Patch

Unfortunately, while this works on trunk, it won't work on older released versions which Venkman still supports, because for...of is an ES Harmony feature, which wasn't available in Fx 3.5, SM 2, etc. (at least, I don't think so?)

Instead, can you just write a plain for loop? Id est:

for (var i = 0; i < node.childNodes.length; i++)
{
    var childNode = node.childNodes[i];
    ... etc. ...

Then I can rubberstamp that and check it in. Thank you for contributing, and sorry the review took a while...

	Michael Kraft [:morac] Assignee
	Comment 5 • 12 years ago

Okay I fixed it the way you stated.

Unfortunately even though this gets Venkman running, it sometimes decides to ignore breakpoints and the like.  Not sure why, but it seems to do with attaching to a window after it opens.  Any way, at least it somewhat works now.

	:Gijs (he/him)
	Comment 6 • 12 years ago

Comment on attachment 703073 [details] [diff] [review]
Patch (v2) [Checked in: Comment 8]

Looks good, thanks!

(do you have push access, or do you need me to push it for you?)

	Michael Kraft [:morac] Assignee
	Comment 7 • 12 years ago

I don't have push access, so please push it for me.  Thanks.

	Ian Neal
	Comment 8 • 12 years ago

Comment on attachment 703073 [details] [diff] [review]
Patch (v2) [Checked in: Comment 8]

http://hg.mozilla.org/venkman/rev/a87d00b27490

	Ian Neal
	Comment 9 • 12 years ago

This is also needed for current aurora (2.17a2) so need to make sure that comm-aurora's client.py pulls a later version than currently ('VENKMAN_RELEASE_0_9_89')