Closed
Bug 826447
Opened 12 years ago
Closed 12 years ago
Make all proxy APIs take |unsigned flags| and not |bool set| in arguments
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
To remove JSRESOLVE_ASSIGNING, we need to remove all things that depend on it. |bool set| arguments often do -- but it's hard to grep for tests of them. Changing to |unsigned flags| arguments, and making all tests use JSRESOLVE_ASSIGNING, makes pellucid all proxy set-dependent behavior.
Note that bholley wanted me to maintain this patch locally and not land it, but the size and scope of this thing makes me think that's really not a good idea. Plus, it's really handy to be able to depend on MXR when surveying the remaining uses of JSRESOLVE_ASSIGNING, which means getting this landed.
This is somewhat mechanical/straightforward, but I'll do a try run before landing to be safe. :-)
Attachment #697628 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 1•12 years ago
|
||
I also added a few MOZ_OVERRIDEs in places where it made sense, since I was already changing overriding methods and it was pretty obvious where it could be used.
Attachment #697628 -
Attachment is obsolete: true
Attachment #697628 -
Flags: review?(bzbarsky)
Attachment #697632 -
Flags: review?(bzbarsky)
Comment 2•12 years ago
|
||
Comment on attachment 697632 [details] [diff] [review]
Guh, qref
Why does the Value* version of get(Own)PropertyDescriptor not change arg order?
r=me modulo that.
Attachment #697632 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b7c8ff502214 checked out, so pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79b2064c1a99
Target Milestone: --- → mozilla20
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•