Closed Bug 826603 Opened 12 years ago Closed 11 years ago

Removing "Stop" and "Refresh" icons from Awesomebar Toolbar Causes Awesomebar to Grow in Height When Text is Entered

Categories

(Firefox :: Theme, defect)

18 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: nb, Assigned: Gijs)

References

Details

Attachments

(3 files)

Attached image mozilla bug.png (deleted) —
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:18.0) Gecko/20100101 Firefox/18.0 Build ID: 20121231071231 Steps to reproduce: I found the bug when upgrading to the latest Firefox 18 Beta Candidate from the latest Firefox 17 release. At some point in the past, I had used 'Customise Toolbar' to remove the 'Stop' and 'Refresh' buttons from my Awesomebar Toolbar. Actual results: When entering text into the Awesomebar, it grew in height and caused the page to reflow due to the window chrome increasing in size. I believe this is due to the 'Go' arrow/icon not maintaining a fixed height when text is entered. See attached file for reference. To reproduce: 1. Create Fresh Firefox Profile 2. about:config -> browser.tabs.onTop 3. Open Context Menu on Awesomebar Toolbar 4. Click 'Customise...' 5. Check 'Use Small Icons' 6. Drag 'Stop' and 'Refresh' buttons off Awesomebar Toolbar 7. Enter Text into Awesomebar - it should grow in height Restoring the icons resolved the issue. Expected results: The Awesomebar Height should remain fixed, the chrome size should not increase and affect the size of the main pane. The 'Go' arrow in the Awesomebar should not grow.
I'm not able to reproduce the issue with Firefox 20 on Win 7 and a new profile. Is it maybe OS-dependant?
Component: Untriaged → Theme
I wasn't able to reproduce this issue either, with MacOS X 10.8.2 and Firefox 18 (the current Firefox Beta).
Hmm. I've just reproduced it again - are either of you using HiDPI displays per chance?
Full HD in my case with resolution at 125% (Win 7).
Bug reproduces on my 15" retina MBP. The analysis of the "go" arrow seems correct - the bookmark star is replaced by an arrow which is too large to fit in the bar. See animated gif, attached.
Attached image animated gif of bug (deleted) —
WFM on Nightly with a Retina MBP.
Oh, I was just reading the title of the bug I duped. I can repro this on Nightly after removing the stop/reload buttons. Given that this has existed for a while and will be fixed by Australis, calling it wontfix. (Although if someone came by with a small patch, I'd actually take it.)
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
I could never replicate in the dupe because it was missing the "remove Stop and Refresh" instructions. It looks to me like the arrow image is missing its width/height attributes. I've seen this exact thing happen before in lots of other HiDPI bugs.
Before bug 907992 was duped, I already wrote a patch. I just tested it. Let's just fix this, also to prevent problems for people switching between Australis and Nightly (even if that might take more work still...)
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WONTFIX → ---
Attached patch Patch (deleted) — Splinter Review
I'm not really decided whether this should be its own selector just for the go-button or if I can just shove it into this one. Either worked fine in my testing for both combined and non-combined stop/reload buttons.
Assignee: nobody → gijskruitbosch+bugs
Status: REOPENED → ASSIGNED
Attachment #793932 - Flags: review?(dao)
Attachment #793932 - Flags: review?(dao) → review+
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Note: when merging m-c to UX, hg decided this now needed to go in the block that no longer had the #go-button selector (as it's gone). I decided otherwise and explicitly removed it.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: