Closed Bug 826619 Opened 12 years ago Closed 8 years ago

Remove mozFillRule

Categories

(Core :: Graphics: Canvas2D, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: Ms2ger, Assigned: wisniewskit)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

Added to the spec in <http://html5.org/tools/web-apps-tracker?from=7634&to=7635>; need to check if our implementation matches that.
The fillRule property has been superseded by CanvasWindingRule and no longer defined in the latest spec. We should just remove mozFillRule.
Attached patch 826619-remove_mozFillRule.diff (deleted) — Splinter Review
Here's a patch which removes mozFillRule, assuming that's still what's desirable. A try run seems fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e4f85e4c5fc
Attachment #8778079 - Flags: review?(bas)
Attachment #8778079 - Flags: review?(bas) → review+
:emk, should I go ahead and mark this as checkin-needed, or has the situation changed since you wrote comment 1?
Assignee: nobody → wisniewskit
Status: NEW → ASSIGNED
Flags: needinfo?(VYV03354)
No changes except that CanvasWindingRule has been renamed to CanvasFillRule. But a DOM peer should sign-off the WebIDL change.
Flags: needinfo?(VYV03354)
:mrbkap, mind signing off on the WebIDL change?
Flags: needinfo?(mrbkap)
r=me on the WebIDL change.
Flags: needinfo?(mrbkap)
Thanks!

Requesting check-in.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca0282fe48b
Remove Canvas mozFillRule. r=mrbkap r=bas
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0ca0282fe48b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Summary: Unprefix mozFillRule → Remove mozFillRule
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: