The context menu for links in private tabs should only offer to 'Open in New Private Tab'. The option to 'Open in New Tab' should be hidden in private tabs to avoid accidental misclicks. The use case to open a non-private tab from within a private tab is rather unusual, IMO. Ian, any thoughts?

Makes sense to me. We are changing the string to read "Open in Private Tab" (removing the New) but I agree that this would probably help prevent misclicks, and that you are unlikely to "go public" by linking out of a private page

Make it so!

Reuses the existing linkOpenableContext impl.

Comment on attachment 704072 [details] [diff] [review] Hide "Open in New Tab" context menu option in private tabs, v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 582244 User impact if declined: allows non-private tabs to be opened from a private browsing tab Testing completed (on m-c, etc.): just landed m-i Risk to taking this patch (and alternatives if risky): very low risk String or UUID changes made by this patch: none

Comment on attachment 704072 [details] [diff] [review] Hide "Open in New Tab" context menu option in private tabs, v2 Approving the low risk patch on aurora , to comply with the new feature . Requesting QA to help with verification of steps mentioned in the description.

Verified Firefox Mobile 20 beta 5 on the Samsung Galaxy Tab 2 7.0 (Android 4.1.1)