Closed
Bug 827010
Opened 12 years ago
Closed 4 years ago
In download views, use async I/O for retrieving data about the target and part files of downloads
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: asaf, Assigned: Gijs)
References
(Regressed 1 open bug)
Details
(Keywords: main-thread-io, perf, Whiteboard: [fxperf:p3])
Attachments
(2 files)
In bug 822343 I'm fixing the new downloads view to use asynce i/o for retrieving data about the target file of downloads.
The same should be done in the downloads panel, and once it's done, we can also fix the new view to use async i/o for part files.
|
||
Updated•11 years ago
|
Keywords: main-thread-io
|
|
||
Updated•11 years ago
|
Blocks: fxdesktopbacklog
|
||
Updated•11 years ago
|
Whiteboard: p=0
|
|
||
Updated•10 years ago
|
|
|
||
Updated•10 years ago
|
Points: --- → 5
Flags: qe-verify-
Whiteboard: p=5 [qa?]
|
||
Comment 1•4 years ago
|
||
This is the code at https://searchfox.org/mozilla-central/rev/d54210d490ef335b13fc1fcac817525120c8c46b/browser/components/downloads/DownloadsViewUI.jsm#740,743 and is still an issue, as shown by the profile in bug 1658202.
Whiteboard: [fxperf]
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [fxperf] → [fxperf:p3]
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D91068
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0a9aecb9e600
avoid main-thread IO from DownloadsViewUI.jsm and use IOUtils to get file size and existence, r=florian
https://hg.mozilla.org/integration/autoland/rev/e67a68917a43
switch to IOUtils instead of OS.File where we can right now, r=florian
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68e10473ea3b
Fix prettier eslint failure on DownloadCore.jsm. r=eslint-fix.
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0a9aecb9e600
https://hg.mozilla.org/mozilla-central/rev/e67a68917a43
https://hg.mozilla.org/mozilla-central/rev/68e10473ea3b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•