Closed
Bug 827082
Opened 12 years ago
Closed 12 years ago
IonMonkey: "Assertion failure: target->isNativeConstructor(),"
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
mozilla20
People
(Reporter: gkw, Assigned: h4writer)
References
Details
(Keywords: assertion, regression, testcase, Whiteboard: [fuzzblocker][jsbugmon:update])
Attachments
(2 files)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
new [].sort()
asserts js debug shell on m-c changeset 20d1a5916ef6 with -ion-eager at Assertion failure: target->isNativeConstructor(),
This is flooding the fuzzer boxes, setting [fuzzblocker].
autoBisect shows this is probably related to the following changeset:
The first bad revision is:
changeset: 117618:67e44e98555c
user: Hannes Verschore
date: Fri Jan 04 17:11:32 2013 +0100
summary: Bug 825705: Creating this on caller-side shouldn't query prototype for unknown objects, r=jandem
|
Reporter | |
Updated•12 years ago
|
Flags: needinfo?(hv1989)
|
Assignee | |
Comment 1•12 years ago
|
||
Something went wrong when copying that code and in this case "CreateThis" should return NULL instead of asserting. This patch should fix it. Trivial patch, but nobody is online to get a quick r+
|
||
Comment 2•12 years ago
|
||
Comment on attachment 698411 [details] [diff] [review]
Fix
We should never call a native non-constructor function with new. This should always result in an error. So returning NULL seems fine.
Attachment #698411 -
Flags: review?(jdemooij) → review?(evilpies)
|
|
||
Updated•12 years ago
|
Attachment #698411 -
Flags: review?(evilpies) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Flags: in-testsuite+
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
|
Reporter | |
Comment 5•12 years ago
|
||
Testcases have been landed by virtue of being marked in-testsuite+ -> VERIFIED as well.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•