Closed
Bug 827227
Opened 12 years ago
Closed 12 years ago
"ASSERTION: rounding error in width reduction???" with SVG, border-image
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jruderman, Assigned: wchen)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
(deleted),
image/svg+xml
|
Details | |
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
testcase
###!!! ASSERTION: rounding error in width reduction???: 'border.left + border.right <= borderImgArea.width && border.top + border.bottom <= borderImgArea.height', file layout/base/nsCSSRendering.cpp, line 3124
This assertion is part of the original code for border-image:
changeset: dda1146d1ec3
user: William Chen
date: Thu Dec 22 18:34:45 2011 -0500
summary: Bug 497995: Part 1 - Implement border-image revisions in latest css3-background spec. r=dbaron
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → wchen
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #705948 -
Flags: review?(dbaron)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 705948 [details] [diff] [review]
Fixed int overflow when scaling border-image-width.
>+ uint32_t combinedBorderWidth = border.left + border.right;
You should (for both width and height) cast these values to uint32_t before the addition rather than waiting until after. And I think you should also add an assertion that the values are positive, which can probably be done in the code above, either right before or right after the assignment to border.Side(s).
r=dbaron with that
Attachment #705948 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•