Closed Bug 827244 Opened 12 years ago Closed 12 years ago

Add system message for PIN-entry

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: sicking, Assigned: allstars.chh)

References

Details

Attachments

(1 file)

The SIM-card can need to ask the the user to enter PIN code anytime. We need a to fire a system message any time this happens so that gaia can display the lock-screen as appropriate. If this needs to be blocking, please nominate appropriately.
blocking-basecamp: --- → ?
Assignee: nobody → allstars.chh
This is the ideal solution, but not sure if the best one for 15 Jan. Can we try to check first if there is a solution for bug 819994 that can be implemented directly in settings app and that does not require changes in the platform?
tracking-b2g18: --- → ?
Flags: needinfo?(frsela)
Attached patch Patch (deleted) — Splinter Review
Attachment #698641 - Flags: review?(vyang)
Comment on attachment 698641 [details] [diff] [review] Patch Review of attachment 698641 [details] [diff] [review]: ----------------------------------------------------------------- r=me :)
Attachment #698641 - Flags: review?(vyang) → review+
Comment on attachment 698641 [details] [diff] [review] Patch Review of attachment 698641 [details] [diff] [review]: ----------------------------------------------------------------- From now on, the system messages need to be granted by appropriate permissions. Please add codes at: dom/messages/SystemMessagePermissionsChecker.jsm Otherwise, the system message cannot be broadcasted as expected.
Attachment #698641 - Flags: review-
(In reply to Gene Lian [:gene] from comment #4) > Comment on attachment 698641 [details] [diff] [review] > Patch > > Review of attachment 698641 [details] [diff] [review]: > ----------------------------------------------------------------- > > From now on, the system messages need to be granted by appropriate > permissions. Please add codes at: > > dom/messages/SystemMessagePermissionsChecker.jsm > > Otherwise, the system message cannot be broadcasted as expected. Can you suggest how to modify the table?
Daniel says we need to block on this.
blocking-basecamp: ? → +
Flags: needinfo?(frsela)
As I just discussed with Evelyn, System app is already listening to oncardstatechange, so she thinks we don't have to modify gecko to send system message. Evelyn, can you check this bug ? thanks
Flags: needinfo?(ehung)
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #7) > As I just discussed with Evelyn, System app is already listening to > oncardstatechange, so she thinks we don't have to modify gecko to send > system message. > > Evelyn, can you check this bug ? > > thanks Evelyn, please also see Bug 819994 comment 27. "However there is no listener for this event so I manually enter the lock screen to get to PIN-entry."
Hi guys, it's looking like we won't need this bug for now. There's another notification which we can use to fix bug 827246
blocking-basecamp: + → ---
(In reply to Jonas Sicking (:sicking) from comment #9) > Hi guys, it's looking like we won't need this bug for now. There's another > notification which we can use to fix bug 827246 Sounds like I misunderstood the initial issue. We still need that :(
blocking-basecamp: --- → +
Blocks: 827246
As I have discussed with Evelyn, Vivien and Francisco, Gaia can handle oncardstatechange in system app, so we don't have to send System message in gecko side. In that case, I would like to mark this bug Invalid and nominate this bug to bb-.
blocking-basecamp: + → ?
Flags: needinfo?(ehung)
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #11) > As I have discussed with Evelyn, Vivien and Francisco, Gaia can handle > oncardstatechange in system app, so we don't have to send System message in > gecko side. > > In that case, I would like to mark this bug Invalid and nominate this bug to > bb-. Okay, I've cleared the nom. Please resolve how you see fit at your convenience.
blocking-basecamp: ? → ---
tracking-b2g18: ? → ---
As we have checked in bug 827246, we don't need a system message for this. We are doing all the work in gaia checking the cardstatechange. Thanks a lot!!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: