+++ This bug was initially created as a clone of Bug #821961 +++ In bug 821961, we added strings with ':' in the keys, which I stupidly r+'ed post-mortem. Actually, ':' is a key-value separator in .properties files, and thus these keys break our infrastructure rather badly, both the l10n dashboard as well as external tools exposing the strings, see https://github.com/transifex/transifex/issues/180 for example. We'll need to fix these strings to use a different glue character, say '.'.

FWIW there were ":" before bug 821961 too. We'll need to gsub everywhere those keys are used since the gecko uses ":" in those permissions names. IIRC: settings/js/apps.js and system/js/permission_manager.js

Let's make sure this goes into triage.

Actually the strings were in Gecko from before bug 821961 but they weren't being used. This can be fixed just in Gaia (by replacing the ':' on the name with a '.' on the definition and then replacing it back to ':' before calling PermissionSettings), or it can be fixed in Gecko. Fixing it in Gecko will probably be better on the long run (because otherwise the day a permission with a '.' on the name is introduced we're going to have funny problems), but requires a little more work: Gecko: * Changing the permissions name in PermissionsTable.jsm Gaia: * After the change makes it to the gecko repository, rerun the permissions name generating script I made to get the correct names. * Fix the manifests for all the apps so they have the correct names.

Comment on attachment 698652 [details] [diff] [review] Patch Review of attachment 698652 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me, thanks for jumping at this quickly.

Oups i removed the flag unintentionally.

Verified fixed in 2013-01-31-07-02-01 pvt nightly b2g18 build