On some devices (e.g. the Ouya) there is no pull-down notifications tray, so there is no way to access the "update available" notification. At least not yet; perhaps the release version of the Ouya will allow this. However I think it makes sense to have the "Check for Updates >>" button on about:firefox turn into an "Install update" button if there is an update available and downloaded. I know that there is an update available and downloaded because I saw this in the logcat: 01-07 15:25:04.580 I/UpdateService( 820): completed update download! 01-07 15:25:04.580 I/UpdateService( 820): have update package at /storage/sdcard0/Download/fennec-20.0a1.multi.android-arm.apk 01-07 15:25:04.600 I/UpdateService( 820): next update will be at: Mon Jan 07 19:23:48 GMT 2013 01-07 15:25:04.600 I/UpdateService( 820): next update will be at: Mon Jan 07 19:23:48 GMT 2013 01-07 15:25:04.670 I/UpdateService( 820): next update will be at: Mon Jan 07 19:25:04 GMT 2013 01-07 15:25:04.920 D/dalvikvm( 820): GC_CONCURRENT freed 1180K, 11% free 11252K/12615K, paused 12ms+11ms, total 36ms 01-07 15:25:05.520 D/GeckoJarReader( 820): Jar reader reached end of stack 01-07 15:25:07.000 I/UpdateService( 820): update available, buildID = 20130107030932 01-07 15:25:07.940 I/UpdateService( 820): using existing update package 01-07 15:25:07.940 I/UpdateService( 820): have update package at /storage/sdcard0/Download/fennec-20.0a1.multi.android-arm.apk

I'm not actually working on this at the moment, so relinquishing it if anybody else wants it. It might make a good mentored bug but I'd have to spend some more time on it before I can be a mentor for it.

Completely untested as of yet but wanted to get some early feedback on the shape of the patch while I go through the nightmare of testing this.

Comment on attachment 723918 [details] [diff] [review] Patch (v2) Since snorp is on PTO also tagging blassey for review. Whoever gets to it first...

Comment on attachment 723918 [details] [diff] [review] Patch (v2) Review of attachment 723918 [details] [diff] [review]: ----------------------------------------------------------------- Not really sure about the about.xhtml stuff, but looks good to me modulo the one nit. ::: mobile/android/base/UpdateService.java @@ +73,5 @@ > > private boolean mDownloading; > private boolean mApplyImmediately; > > + private enum CheckUpdateResult { Seems like this should go in UpdateServiceHelper, which has other things that are shared between the update service and users of it.

Sorry but you can't do this -<!ENTITY aboutPage.checkForUpdates.found "Update available"> +<!ENTITY aboutPage.checkForUpdates.found "Update available; click to download"> This kind of string change requires a new entity name. Not sure if you want to reopen this bug or open a new one depending on this to fix it.

Also (sorry for the double comment): do you really want to use "click to" on Android? Similar strings in base/android_strings.dtd use the form "Touch to X".

(In reply to Francesco Lodolo [:flod] from comment #8) > This kind of string change requires a new entity name. > Oh, sorry. Thanks for pointing this out! > Not sure if you want to reopen this bug or open a new one depending on this > to fix it. I'll do it here. (In reply to Francesco Lodolo [:flod] from comment #9) > Also (sorry for the double comment): do you really want to use "click to" on > Android? Similar strings in base/android_strings.dtd use the form "Touch to > X". The primary use case I wanted this patch was for the Ouya which doesn't have a touch screen, so I prefer using "Click" in this case.

Comment on attachment 724902 [details] [diff] [review] Update entity name Looks good to me, but I'm not a reviewer (given f+ anyway) ;-)

Verified fixed on: -build: Firefox for Android 23.0a1 (2013-04-08) -device: Samsung Galaxy Nexus -OS: Android 4.1.1