Closed
Bug 827359
Opened 12 years ago
Closed 8 years ago
WebRTC signal processing doesn't do runtime detection of NEON
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
RESOLVED
FIXED
| backlog | webrtc/webaudio+ |
People
(Reporter: gcp, Assigned: gcp)
References
Details
(Whiteboard: [leave-open])
Attachments
(1 file)
|
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=812650#c6
This is because the current code is assuming ARMv7 always implies NEON. This is fixed upstream, so bug 818631 will fix it.
A patch to disable NEON will work around the issue for now, but not sure what to think of taking the performance penalty - it only really breaks Tegra 2 devices, but those aren't exceptional.
|
Assignee | |
Updated•12 years ago
|
Blocks: 812650
Depends on: webrtc_updates
|
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → gpascutto
Attachment #698746 -
Flags: review?(rjesup)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 698746 [details] [diff] [review]
Patch 1. Disable NEON acceleration for now.
Review of attachment 698746 [details] [diff] [review]:
-----------------------------------------------------------------
Link it to the webrtc-updates bug so we know to look to back it out after we update
Attachment #698746 -
Flags: review?(rjesup) → review+
|
||
Comment 3•12 years ago
|
||
Once we update the webrtc.org code, we will want to back this out. Making webrtc-blocking+ and marking leave-open so we remember to back this out after our update.
Priority: -- → P2
Whiteboard: [WebRTC], [blocking-webrtc+][leave-open]
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
|
|
||
Comment 6•12 years ago
|
||
The current 3.20 merge patchset resolves this
Depends on: 830247
Whiteboard: [WebRTC], [blocking-webrtc+][leave-open] → [WebRTC], [blocking-webrtc-][leave-open]
|
||
Updated•9 years ago
|
backlog: --- → webRTC+
Rank: 25
Whiteboard: [WebRTC], [blocking-webrtc-][leave-open] → [leave-open]
|
||
Comment 7•8 years ago
|
||
I'm pretty sure the patch is no longer in our tree.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•