ji Reporter
	Description • 23 years ago

****Observed with 05/25 trunk build*****

When importing settings from Outlook Express Japanese, the Japanese username is
not imported correctly.

Steps to reproduce:
1. Setup Outlook Express mail account using a Japanese username.
2. Launch Mail.
3. Select File | Import
4. Select Settings and click on Next.
5. Select Outlook Express and click on Next to finish the importing.
6. Go to Account Manager by select Edit | Mail/News Account Settings.
7. Select the account you just imported from OE.
   You'll see the username in Your Name field is garbled. It's not imported
correctly.

	ji Reporter
	Comment 1 • 23 years ago

ame problem occurs when setting up OE using a Japanese mail account name. After
importing, the Japanese account name is shown garbled both in the account
manager and 3-pane.

	nhottanscp
	Comment 2 • 23 years ago

Please attach a screen shot of the problem. Is this a regression from NS6?

Reassign to putterman.

	scottputterman
	Comment 3 • 23 years ago

reassigning to chuang.

	Makoto Kato [:m_kato]
	Comment 5 • 23 years ago

add me

	nhottanscp
	Comment 7 • 23 years ago

Kato san, you need to get r= from module owner before asking for sr=.
So please get this also reviewed by chuang (or the current module owner).
Here is my comment for the patch.

* containsChildNamed is changed to take wstring but I don't see a change for
GetChildNamed, GetChildNamed still takes char*.
http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgFolder.cpp#1201
* Change to nsAutoString, +  nsString uniqueName;
* I think the helper funcition ConvertToUnicode is not needed. The class can
hold an instance of nsIImportService to use nsIImportService::SystemStringToUnicode.

	chuang
	Comment 8 • 23 years ago

I did see GetChildNamed() is changed.  Please change uniqueName to nsAutoString.
I am not sure about the 3rd, Naoki should know it better.  Please make sure it
won't break in the English.

r=chuang.  

	nhottanscp
	Comment 9 • 23 years ago

That's right, GetChildNamed() is changed, that is at the top of the patch.

	ji Reporter
	Comment 10 • 23 years ago

With the latest trunk build, account name imported from Outlook Express always
has the name of "Outlook Express" initially. But the identity showing in "From:"
field on a mail compose window is garbled after Settings import.

	ji Reporter
	Comment 11 • 23 years ago

Niminating for nsbeta1 since this is a data loss and with the current
implementation, there is no UI for users to correct the corrcupted identity
after import.

	ji Reporter
	Comment 12 • 23 years ago

Same problem exsists when import from Chinese OE6.0

	scottputterman
	Comment 13 • 23 years ago

reassigning to cavin.

	Jennifer Mulcaster
	Comment 14 • 23 years ago

removing jenm as cc:
adding evelyn prime macadam

	Evelyn Prime-MacAdam
	Comment 15 • 23 years ago

ccing greggl, removing evelyn

	ji Reporter
	Comment 16 • 23 years ago

Could we reconsider this for the next release? Again this is a data loss and no
UI for users to correct. And the identity is in unicode in prefs.js. There is no
unicode text editor coming with operating systems, so there is no easy way to
manually edit the prefs.js file to correct this.

	Jennifer Mulcaster
	Comment 17 • 23 years ago

adding evelyn as a cc
removing jenm

	Jennifer Mulcaster
	Comment 18 • 23 years ago

removed jenm as cc

	Michael Buckland
	Comment 19 • 23 years ago

Discussed in 2/25 Mail News bug meeting.  We need to know whether or not the
user can fix the garbled info (or perhaps it's now "Outlook Express" in a more
recent build) in the Account Settings dialog by going Edit|Mail & Newsgroups
Account Settings...and editing the problematic text there.  If the user does
this will the  problem be addressed?

	ji Reporter
	Comment 20 • 23 years ago

Checked this with 02/25 build. Now the identity part shows on account manager UI along with account name. It used to show the account name only.
So with this implementation, users can correct the corrupted identity from UI.

	Michael Buckland
	Comment 21 • 23 years ago

Discussed in 2/28/02 Mail & News bug meeting.  Decisions was to minus this bug
again because a workaround exists.  Thanks, ji for the info.

	nhottanscp
	Comment 22 • 22 years ago

*** Bug 159216 has been marked as a duplicate of this bug. ***

	nhottanscp
	Comment 23 • 22 years ago

nominate for nsbeta1

	ji Reporter
	Comment 24 • 22 years ago

Same problem happens for import from Outlook.

	Cavin Song Assignee
	Comment 25 • 22 years ago

Need to convert acct name and username to unicode. Also, organization name is
now imported (was missing before).

	nhottanscp
	Comment 26 • 22 years ago

Comment on attachment 103392 [details] [diff] [review]
Proposed patch, v1

* please check return value of SystemStringToUnicode and GetAccountName
* for GetAccountName, how about use PRUnichar** since the callers need it
eventually?
* use CopyASCIItoUCS2 instead of AssignWithConversion

	nhottanscp
	Comment 27 • 22 years ago

*** Bug 159202 has been marked as a duplicate of this bug. ***

	Cavin Song Assignee
	Comment 28 • 22 years ago

Incorporated comment.

	Cavin Song Assignee
	Comment 29 • 22 years ago

Wrong patch. This is the right one.

	nhottanscp
	Comment 30 • 22 years ago

Comment on attachment 103409 [details] [diff] [review]
Proposed patch, v2

r=nhotta

sorry, I forgot that CopyASCIItoUCS2 does not take char*,
please do acctName.Assign(NS_ConvertASCIItoUCS2(defaultName));
or
CopyASCIItoUCS2(nsCAutoString(defaultName), acctName);

	Cavin Song Assignee
	Comment 31 • 22 years ago

OK, I'll do that before checking the code in.

	(not reading, please use seth@sspitzer.org instead)
	Comment 32 • 22 years ago

sr=sspitzer, once you follow all of nhotta's strings recommendations.

	Cavin Song Assignee
	Comment 33 • 22 years ago

Adding [fixedish1] to statue whiteboard.

	ji Reporter
	Comment 34 • 22 years ago

The problem is not seen anymore when importing from OE, but I still see the
error described in bug 159202 when importing from Ja Outlook. On Outlook, I
changed the Japanese account name and username to English, but the error still
occurs.

	Cavin Song Assignee
	Comment 35 • 22 years ago

Fix checked in to the trunk.