Open Bug 827603 Opened 12 years ago Updated 2 years ago

[jsdbg2] Debugger constructor accepts non-globals as arguments

Categories

(Core :: JavaScript Engine, defect)

defect

Tracking

()

ASSIGNED

People

(Reporter: jimb, Assigned: jimb)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

A while back, we decided that only actual global objects, or safely-unwrappable wrappers around such, or Debugger.Object instances referring to either of the above, should be permitted as ways to identify debuggees to addDebuggee, removeDebuggee, and hasDebuggee, to provide a more capability-like security model for the debugger. When we implemented this, we forgot to change the Debugger constructor, which adds its arguments as debuggees.
Assignee: general → jimb
Status: NEW → ASSIGNED
Attachment #698950 - Flags: review?(jorendorff)
Severity: normal → minor
Flags: in-testsuite+
Comment on attachment 698950 [details] [diff] [review] Make Debugger constructor accept only the same kinds of debuggee designators as addDebuggee and friends. Review of attachment 698950 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #698950 - Flags: review?(jorendorff) → review+
jimb: did you forget to land this r+'d patch from January 2013? Is it still relevant?
Flags: needinfo?(jimb)
Yes, I forgot to land it. Thanks very much!
Flags: needinfo?(jimb)
A fresh try push, seeing as this is six months old: https://tbpl.mozilla.org/?tree=Try&rev=e55e14dae2cd
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: