Open
Bug 827603
Opened 12 years ago
Updated 2 years ago
[jsdbg2] Debugger constructor accepts non-globals as arguments
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
ASSIGNED
People
(Reporter: jimb, Assigned: jimb)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
A while back, we decided that only actual global objects, or safely-unwrappable wrappers around such, or Debugger.Object instances referring to either of the above, should be permitted as ways to identify debuggees to addDebuggee, removeDebuggee, and hasDebuggee, to provide a more capability-like security model for the debugger. When we implemented this, we forgot to change the Debugger constructor, which adds its arguments as debuggees.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Severity: normal → minor
Flags: in-testsuite+
Comment 2•12 years ago
|
||
Comment on attachment 698950 [details] [diff] [review]
Make Debugger constructor accept only the same kinds of debuggee designators as addDebuggee and friends.
Review of attachment 698950 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
Attachment #698950 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•11 years ago
|
||
jimb: did you forget to land this r+'d patch from January 2013? Is it still relevant?
Flags: needinfo?(jimb)
Assignee | ||
Comment 6•10 years ago
|
||
A fresh try push, seeing as this is six months old:
https://tbpl.mozilla.org/?tree=Try&rev=e55e14dae2cd
Updated•4 years ago
|
Blocks: js-debugger
Updated•2 years ago
|
Severity: minor → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•