(no longer active) Assignee
	Description • 12 years ago

This is stupid, and I got fed up with it!

	(no longer active) Assignee
	Comment 1 • 12 years ago

Over to Ted for the Makefile review and to Jeff for the rest.

	Jeff Muizelaar [:jrmuizel]
	Comment 2 • 12 years ago

Comment on attachment 699342 [details] [diff] [review]
Patch (v1)

Review of attachment 699342 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/genTables.py
@@ +3,4 @@
>  def table_generator(f):
>      return ",\n".join([", ".join(["0x%2.2x" % h for h in [f(i) for i in range(r,r+16)]]) for r in range(0, 65536, 16)])
>  
> +f = open("PremultiplyTable.h", "w")

PremulitplyTables.h

	(not currently active) Ted Mielczarek
	Comment 3 • 12 years ago

Comment on attachment 699342 [details] [diff] [review]
Patch (v1)

Review of attachment 699342 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/Makefile.in
@@ +394,4 @@
>  endif
>  endif
>  
> +PremultiplyTable.h:

This should depend on genTables.py.

::: gfx/thebes/genTables.py
@@ +13,1 @@
>  f.close()

You could switch this to use
with open("PremultiplyTable.h", "w") as f:
    f.write(...)

and drop the close.

	(not currently active) Ted Mielczarek
	Comment 4 • 12 years ago

Also, this is why we shouldn't let non-build peers review Makefile changes.

	(no longer active) Assignee
	Comment 5 • 12 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Also, this is why we shouldn't let non-build peers review Makefile changes.

Good material for a blog post.  ;-)

	(no longer active) Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc2539dbe5f0

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/fc2539dbe5f0

	Justin Lebar (not reading bugmail)
	Comment 8 • 12 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Also, this is why we shouldn't let non-build peers review Makefile changes.

FWIW, I did suggest this exact Makefile change in the bug.  But I also suggested using PHONY as an alternative; I guess that was my mistake.  I'm sorry.