User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 Build ID: 20130104154748 Steps to reproduce: In a test server of bedrock, modify one of lib/product_details_json/firefox_primary_builds.json lib/product_details_json/firefox_beta_builds.json to include an entry for Linux64. Actual results: Accessing http://127.0.0.1:8000/en-US/firefox/all/ (or the corresponding URL) displays a crash message complaining: KeyError at /firefox/all/ u'Linux64' Request Method: GET Request URL: http://127.0.0.1:8000/en-US/firefox/all/ Django Version: 1.3.1 Exception Type: KeyError Exception Value: u'Linux64' Exception Location: /home/elideb/development/mozilla.org/bedrock/apps/firefox/firefox_details.py in get_download_url, line 112 Python Executable: /home/elideb/development/mozilla.org/bedrock/venv/bin/python Python Version: 2.7.3 Expected results: The server should be able to parse Linux64 entries properly, as they will be added to the list of offered platforms soon. Explicit support, instead of ignoring unknown platforms, would be desirable to quickly detect mistakes in the generation of product details.

I'm not sure if this crashes any other pages, but it might be worth looking around to see what else crashes when Linux64 builds are available. Channel and fx/#desktop work properly. Don't know about the old site, which depends on the PHP files in http://svn.mozilla.org/libs/product-details/ (ths json ones are generated from those, so they cannot be modified independently). The old version of all.html did crash, but it shouldn't be a problem now that the sandstone version has been published. Bug 527907 and adding Linux64 entries to Product Details should be held back until we can ensure nothing crashes.

Created https://github.com/mozilla/bedrock/pull/577 to fix issue in bedrock. all.html properly loads when Linux64 builds are present in product details. Still, old PHP pages using product details might crash.

Example of a modified product details json file (firefox_primary_builds.json), by the way: { "ach":{ "19.0a2":{"Windows":{"filesize":0},"OS X":{"filesize":0},"Linux":{"filesize":0}}, "18.0b7":{"Windows":{"filesize":7.8},"OS X":{"filesize":19},"Linux":{"filesize":9.6}}, "18.0":{"Windows":{"filesize":7.8},"OS X":{"filesize":19},"Linux":{"filesize":9.6},"Linux64":{"filesize":9.6}}}, "af":{ "3.6.28":{"Windows":{"filesize":7.6},"OS X":{"filesize":17.4},"Linux":{"filesize":9.2}}, "18.0b7":{"Windows":{"filesize":7.8},"OS X":{"filesize":19},"Linux":{"filesize":9.6}}, "19.0a2":{"Windows":{"filesize":0},"OS X":{"filesize":0},"Linux":{"filesize":0}}, "18.0":{"Windows":{"filesize":7.8},"OS X":{"filesize":19},"Linux":{"filesize":9.6},"Linux64":{"filesize":9.6}}, "10.0.12esr":{"Windows":{"filesize":7.8},"OS X":{"filesize":19},"Linux":{"filesize":9.6}}} ...

https://www.mozilla.org/en-US/firefox/organizations/all.html still uses the PHP version of product details, so it would be broken if we added Linux64. It is being ported to bedrock in bug 811762.

https://www.mozilla.org/en-US/firefox/all-beta.html https://www.mozilla.org/en-US/firefox/all-aurora.html Also use PHP product_details and should be tested.

We are serving linux64 builds without adding linux64 entries to product-details, and it's working well. We could revisit this when win64 builds are added in the future.