Please exclude 17.0.2-17.0.x from the function that determines http://www.mozilla.org/en-US/firefox/update/, to prevent bug 828009 server-side. These versions are part of the ESR and are on a different update schedule.

(In reply to Alex Keybl [:akeybl] from comment #0) > Please exclude 17.0.2-17.0.x from the function that determines > http://www.mozilla.org/en-US/firefox/update/, to prevent bug 828009 > server-side. These versions are part of the ESR and are on a different > update schedule. Can you verify the versions again? 17.0.2 to what version? .2 to .x? Wouldn't that match non-ESR people that are running 17.0.1?

Is "esr" anywhere in the user agent string that we can match on?

(In reply to Chris More [:cmore] from comment #1) > (In reply to Alex Keybl [:akeybl] from comment #0) > > Please exclude 17.0.2-17.0.x from the function that determines > > http://www.mozilla.org/en-US/firefox/update/, to prevent bug 828009 > > server-side. These versions are part of the ESR and are on a different > > update schedule. > > Can you verify the versions again? > > 17.0.2 to what version? .2 to .x? to infinity > Wouldn't that match non-ESR people that are running 17.0.1? not if we exclude .0 and .1.

(In reply to Chris More [:cmore] from comment #2) > Is "esr" anywhere in the user agent string that we can match on? Nope - we don't want sites to act differently for enterprise versions of Firefox.

(except when we do, like here)

To expand on Comment 3, there are no non-ESR users on 17.0.2 or 17.0.{2,3,4,...}

Ok, to speak regex: ^17\.0\.[2-9]*$ for the version, right? Your initial email looked like it was reversed, but I think my regex is what you mean. This match should be excluded from the update notification. Will this ever happen in the future or should be consider this a one-off?

I think we need ^17\.0\.[2-9]$ and ^17\.0\.[1-9][0-9]$ which should cover 2-99. The other one would miss 17.0.1{0,1} I think. Any Firefox UA that matches that should be considered up to date as a simple workaround to prevent ESR confusion.

Could do it with one regex: ^17\.0\.([2-9][0-9]?){0,1}$ That should match 2-99. From my previous question, will this happen in the future again or is this a one-time issue that needs an exception?

pmac/mkelly: Can you check into where we would have to put this exception to keep /firefox/update/ from saying the Firefox users in comment 9 are out of date? This is causing people to update out of the ESR model from IT shops around the world. This should be a one-off exception. This appears to be a high priority of Firefox engineering and the scenario is described in bug 828009.

(In reply to Chris More [:cmore] from comment #9) > From my previous question, will this happen in the future again or is this a > one-time issue that needs an exception? It'll happen for ESR24 as well, as long as we decide to move forward with the current long-term support situation.

Sounds like 17.0.2 is no different than 17.0.0 in the UA. Let's just not show a message (up to date or outdated) for 17.* for now, until bug 828009 is resolved.

This change can be limited to http://www.mozilla.org/en-US/firefox/update/ if at all possible.

The latest ESR in product-details is 10.0.12esr. Should 10.x be excluded from this as well?

Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/74095668d2dbfea8c57fd5ae49690aa692657d56 Bug 828064: Do not redirect ESR firefox to update.

I believe the above commit will fix the issue of the users seeing the /firefox/update/ page. There are other pages around the /firefox/* area that will still indicate that the browser is out-of-date however. I've got a PR in that should fix these as well as soon as its reviewed. My hope is that we can push these changes to production tomorrow. PR: https://github.com/mozilla/bedrock/pull/585

Pushed the commit from comment 15 to prod. Other is still in review.

I've refactored the outstanding PR for this bug and opened a new PR here for review: https://github.com/mozilla/bedrock/pull/866

Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/7e424e507623432ecfaf3c0f819a8b11892e8eca Firefox pages js should consider esr builds up to date bug 828064 tidy up tidy up again stick to js variable naming convention update devices.js to include esr releases Update template, l10n amends, minor JS tweaks insert new line at EOF remove local variables no longer needed tidy up remove old context_processors file post update https://github.com/mozilla/bedrock/commit/4bcccd8e446d93ba4cf95fb4e7b1b4f906e8d2ff Merge pull request #866 from alexgibson/firefox-page-js-consider-esr-up2date-bug-828064 Firefox pages JS should consider ESR builds up to date bug 828064