Closed
Bug 828120
Opened 12 years ago
Closed 12 years ago
social panel buttons are too wide on Mac
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 21
People
(Reporter: Gavin, Assigned: jaws)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
Screenshot of patch
|
Reporter | |
Updated•12 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•12 years ago
|
||
This combines the buttons and removes the extra margins that were noted before.
As I mentioned in the previous bug, the toolbaritems are still a bit too wide, but I can't figure out how to get them any narrower.
Attachment #699816 -
Flags: review?(mnoorenberghe+bmo)
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•12 years ago
|
||
Comment on attachment 699816 [details] [diff] [review]
Patch
Review of attachment 699816 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with the change
::: browser/themes/pinstripe/browser.css
@@ +3815,5 @@
> }
>
> +/* Needed to make the adjacent buttons combine */
> +.social-notification-container > .toolbarbutton-1,
> +#social-provider-button {
The comment is only for the second rule and since the margin has a different purpose for each rule, the property can be moved to the two existing rulesets:
#social-provider-button
.social-notification-container > .toolbarbutton-1
Attachment #699816 -
Flags: review?(mnoorenberghe+bmo) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Thanks, I made the changes on the patch that got landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6c4fd2603f9
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
|
||
Comment 6•12 years ago
|
||
|
|
||
Comment 7•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•