Closed
Bug 828293
Opened 12 years ago
Closed 12 years ago
Root js_NativeSet's vp argument
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #699742 -
Flags: review?(terrence)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 699742 [details] [diff] [review]
Patch v1
Review of attachment 699742 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsobj.cpp
@@ +3311,5 @@
> * unless the setter deleted the shape.
> */
> if (shape->hasSlot() &&
> (JS_LIKELY(cx->runtime->propertyRemovals == sample) ||
> obj->nativeContains(cx, shape))) {
Since you're here, move the brace to a new line.
@@ +3312,5 @@
> */
> if (shape->hasSlot() &&
> (JS_LIKELY(cx->runtime->propertyRemovals == sample) ||
> obj->nativeContains(cx, shape))) {
> + AddTypePropertyId(cx, obj, shape->propid(), ovp);
I would think that vp.get() would work here instead of having to re-root it: if that doesn't work we should figure out why.
Attachment #699742 -
Flags: review?(terrence) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
(In reply to Terrence Cole [:terrence] from comment #1)
> Comment on attachment 699742 [details] [diff] [review]
> Patch v1
>
> Review of attachment 699742 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: js/src/jsobj.cpp
> @@ +3311,5 @@
> > * unless the setter deleted the shape.
> > */
> > if (shape->hasSlot() &&
> > (JS_LIKELY(cx->runtime->propertyRemovals == sample) ||
> > obj->nativeContains(cx, shape))) {
>
> Since you're here, move the brace to a new line.
>
> @@ +3312,5 @@
> > */
> > if (shape->hasSlot() &&
> > (JS_LIKELY(cx->runtime->propertyRemovals == sample) ||
> > obj->nativeContains(cx, shape))) {
> > + AddTypePropertyId(cx, obj, shape->propid(), ovp);
>
> I would think that vp.get() would work here instead of having to re-root it:
> if that doesn't work we should figure out why.
I think because vp has changed by then.
|
|
Assignee | |
Updated•12 years ago
|
Blocks: ExactRooting
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•