Closed
Bug 828690
Opened 12 years ago
Closed 12 years ago
GC: Return Unrooted from StringBuffer::finish
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
This is causing us problems right now. I want to think about what to do with setGuessedAtom's parameters a bit more before changing them.
Attachment #700056 -
Flags: review?(evilpies)
|
Assignee | |
Comment 1•12 years ago
|
||
Okay, it turns out the prior patch totally messed up JSAtom's namespace exposure. The real solution turns out to be a bit annoying. We will need to revisit the hunk in jsprvtd.h.
Assignee: general → terrence
Attachment #700056 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #700056 -
Flags: review?(evilpies)
Attachment #700080 -
Flags: review?(sphink)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 700080 [details] [diff] [review]
v1
Whoops, I meant to flag Bill for review on this.
Attachment #700080 -
Flags: review?(sphink) → review?(wmccloskey)
Comment on attachment 700080 [details] [diff] [review]
v1
Review of attachment 700080 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsprvtd.h
@@ +201,5 @@
> typedef JSAtom * RawAtom;
> +#ifdef DEBUG
> +typedef JSAtom * UnrootedAtom;
> +#else
> +typedef Unrooted<JSAtom*> UnrootedAtom;
As we discussed, can you just use the normal ForwardDeclareJS(Atom) for these (and not put them in jsprvtd.h)?
Attachment #700080 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•