David Teller [:Yoric] - still alive but not very active Reporter
	Description • 12 years ago

First, Twitter reverted to the default "rocket" icon.
Just now, Entanglement reverted to the default "rocket" icon.

A few minutes before, I had received notification of an update to Entanglement, and for some reason, wifi was deactivated when I chose to perform that update. I believe this is when the icon was lost.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 1 • 12 years ago

I wonder if this is caused by the code at:  https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/page.js#L157 that tries to get an icon while the phone is offline and when it fails it removes the old icons and register the default one.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 2 • 12 years ago

I think we should block on it if that's the case since this will result in many homescreen 'breakage' for users.

	Cristian Rodriguez (:crdlc)
	Comment 3 • 12 years ago

I really think so

	Hubert Figuiere [:hub]
	Comment 4 • 12 years ago

I'll take it

	Marcia Knous [:marcia]
	Comment 5 • 12 years ago

Haven't see this yet today testing, I added the icons he referenced so we will see what happens.

	Andreas Gal :gal
	Comment 6 • 12 years ago

How are we doing here?

	David Teller [:Yoric] - still alive but not very active Reporter
	Comment 7 • 12 years ago

I don't know if this is a fix or a side-effect of the upgrade, but with the latest version on the beta channel, the applications have recovered their expected icons.

	Dale Harvey (:daleharvey) Assignee
	Comment 8 • 12 years ago

I am investigating why this would have happened and if it is fixed now

	Dale Harvey (:daleharvey) Assignee
	Comment 9 • 12 years ago

This is a quick fix for the specific case of losing the network in between downloading an update and applying it. I think going forward on any update we should prefetch any remote icons and store them locally, I found other bugs due to the fact we are using icon urls as opposed to cached

https://bugzilla.mozilla.org/show_bug.cgi?id=829552

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 10 • 12 years ago

Comment on attachment 701022 [details]
Dont revert icons when losing network during update

Sounds good to me since this is what I was assuming. Thanks for spending time to reproduce the issue!

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 11 • 12 years ago

https://github.com/mozilla-b2g/gaia/commit/bd14bfdd4ab065d4870201e155e88564267451ef

	Jason Smith [:jsmith]
	Comment 12 • 12 years ago

Tested a couple of data connection lost scenarios - looks okay on 1/22 build.

	Juan Perez-Bedmar [:juanpbf]
	Comment 13 • 11 years ago

I have reproduced this issue again on Ikura. 

Details of the version:
gaia commit:
f80afc3 Merge pull request #9055 from yurenju/bug-846197-v1.0.1
gecko commit:
8ed9c99 Bug 859552: Fix inari boot image. r=nthomas a=akeybl
RIL version:AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.19.046

This bug should be reopened and linked into the [meta] for Spain certification blockers, for tracking purposes

	Juan Perez-Bedmar [:juanpbf]
	Comment 14 • 11 years ago

Picture attached for clarification, in case someone needs it