Build: B2G 18 1/10/2013 Device: Unagi Steps: 1. With the marketplace having X manifest on your device, ask the marketplace team nicely to someone cause the update to happen 2. Check for updates (manual or automatic) 3. Apply the update available from the update notification Expected: The update should applied - no repeated prompts should be seen. Actual: After applying an update, the update available prompt appears again. If I then try to apply the update, the update available prompt appears following the update again as well. What's going wrong here? Are we even applying an update here? Firing an update available unexpectedly?

Julien mentioned that he managed to reproduce this as well yesterday. I just got this to reproduce on today's build.

Damn, I'm pretty sure we fixed that at some point before.

Here's the state of marketplace I have on my device right now with an update available: "marketplace": { "origin": "https://marketplace.firefox.com/telefonica/", "installOrigin": "https://marketplace.firefox.com/telefonica/", "receipt": null, "installTime": 132333986000, "manifestURL": "https://marketplace.firefox.com/telefonica/manifest.webapp", "localId": 1021, "etag": "\"2a5aa6f98e39355390293b78b4c27204\"", "packageEtag": null, "basePath": "/data/local/webapps", "id": "marketplace", "removable": false, "name": "Firefox Marketplace", "csp": "", "lastCheckedUpdate": 1357819234185, "installState": "installed", "downloading": false, "downloadSize": 0, "readyToApplyDownload": false, "downloadAvailable": false, "updateTime": 1357818874742, "retryingDownload": false },

Regression + major broken = bb+

Talked with Fabrice on this one. What's weird about this is that the values are all false above, implying that we shouldn't be getting an update fired to Gaia. But Gaia appears to be getting the update repeatedly. Etienne - Any ideas?

If downloadAvailable is false in webapps.json then it can be: - we didn't clean on the gaia side after the update (are you still seeing the notification after a reboot?) - we're actually somehow getting a ondownloadavailable callback

I think I found this bug and fixed this in Bug 826946. The problem was that at reboot for some reason, the install manager would register the events on the app even if it was installed whereas it should do that only for pending apps. Therefore, the downloadsuccess event was never received by the update manager, and therefore the update was never applied. Instead, we get the "app installed" banner which we shouldn't have at update.

Ok, there is something else happening, I'm trying to investigate more.

Julien's going to check whether or not this was fixed as part of another bug. If Fabrice and Julien are too busy, Andrea can perhaps help.

This seems fixed for me. Closing it for now, please reopen if I'm wrong.