Closed Bug 828965 Opened 12 years ago Closed 11 years ago

[Camera] Geolocation permissions screen does not appear if launching camera from lockscreen

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:leo+, blocking-basecamp:-, b2g18+ fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
blocking-basecamp -
Tracking Status
b2g18 + fixed
b2g-v1.1hd --- fixed

People

(Reporter: tchung, Assigned: alive)

References

()

Details

(Whiteboard: [TD-41869])

Attachments

(3 files)

Attached image screenshot (deleted) —
The geolocation permissions screen needs to also appear if the user is enabling the camera from lockscreen mode. It currently only shows if launching Camera from behind the lockscreen. bb+ because its required to prompt users on determining geo permissions, since camera uses it by default Screenshot of permissions page Repro: 1) install 20130110080534 nightly unagi build 2) on the lockscreen, click the camera button to launch from lockscreen 3) Camera appears, and you can use it to take pictures, etc.. 4) go back to locksceen, and unlock to get back into the home page 5) launch camera app 6) Verify geo permissions page occurs then. Expected: - geo permissions page if launching camera from lockscreen Actual: - no geo permissions page
blocking-basecamp: ? → +
Priority: -- → P1
Target Milestone: --- → B2G C4 (2jan on)
Assignee: nobody → dale
Dale, can you tell us whether the camera would use and record geolocation data in this scenario, or would it behave as if you had denied geoloc permission? If the latter, then I don't think this is a blocker.
Flags: needinfo?(dale)
Investigating now Either we implictly grant the permission and camera will use it, or we have a bug showing the prompt
Flags: needinfo?(dale)
It is a bug with showing the permission prompt (likely underneath the lockscreen) and so will will not use or have access to the users location. Renoming as it is not a privacy issue
blocking-basecamp: + → ?
Thanks, blocking- Marked tracking-b2g for further consideration but seems like a minor issue and current behavior might be preferable since you're in a hurry to get a picture and don't want to be interrupted at that time for geoloc permisssion.
blocking-basecamp: ? → -
tracking-b2g18: --- → +
(In reply to Dale Harvey (:daleharvey) from comment #3) > It is a bug with showing the permission prompt (likely underneath the > lockscreen) and so will will not use or have access to the users location. Doesn't this mean geotagging of photos from the lock screen will be broken? (even if the user taps "Allow", the photos have already been saved, presumably w/out geolocation, at the point when the user see the dialog)
FWIW -- to be clear: with passcode lock enabled, the Geolocation dialog does appear for the camera, but it's in the background, so I don't see it until I've actually fully-unlocked my phone. (and then it's kind of a surprise, since I'm not using the camera anymore) Should I file a separate bug on that, or is that covered by this bug?
Yeh that is covered by this bug
Deassigning myself from bugs I am not currently working on (this bug seems like it might need triaged though)
Assignee: dale → nobody
blocking-b2g: --- → leo?
Fabrice confirmed that the camera *does not* store the location in this instance, so this is blocking-, tracking+.
blocking-b2g: leo? → -
blocking-b2g: - → leo+
(In reply to Daniel Holbert [:dholbert] from comment #6) > FWIW -- to be clear: with passcode lock enabled, the Geolocation dialog does > appear for the camera, but it's in the background, so I don't see it until > I've actually fully-unlocked my phone. (and then it's kind of a surprise, > since I'm not using the camera anymore) > > Should I file a separate bug on that, or is that covered by this bug? When it's run from passcode lockscreen, the Geolocation dialog appears in background "every time it runs". To better explain the problem, the 'remember' option in the Geolocation dialog does not work when it's run from passcode lockscreen.
Whiteboard: [TD-41869]
The permission dialog is at background because https://bugzilla.mozilla.org/show_bug.cgi?id=852013 and https://bugzilla.mozilla.org/show_bug.cgi?id=853711 The remember me option in this case doesn't work maybe because the secure camera is living in system app but in the other case the camera is the normal camera. They are different apps.
Target Milestone: B2G C4 (2jan on) → 1.1 QE3 (24jun)
Assignee: nobody → alive
Attached file Repro video (deleted) —
(In reply to Alive Kuo [:alive] from comment #11) Yes, they are different apps. The 'remember' option in normal camera works fine. But the 'remember' option in secure camera (in the Geolocation dialog from the passcode lockscreen) does not work fine. (Frequency rate: 30%) It sometimes doesn't 'remember' the selection. Please refer to the attachment video. 00:13 - Ask for the permission "1st time" ... - Keep trying to repro, doing random things in between. 02:12 - Ask for the permission "2nd time" There were times when the frequency rate was very high. I was told that the 'remember' option might not be saved, since the caller iframe is closed when the Geolocation dialog is closed.
Attachment #762502 - Flags: feedback?(alive)
(In reply to hanj.kim25 from comment #12) > Created attachment 762502 [details] > Repro video > > (In reply to Alive Kuo [:alive] from comment #11) > > Yes, they are different apps. The 'remember' option in normal camera works > fine. But the 'remember' option in secure camera (in the Geolocation dialog > from the passcode lockscreen) does not work fine. (Frequency rate: 30%) It > sometimes doesn't 'remember' the selection. > > Please refer to the attachment video. > > 00:13 - Ask for the permission "1st time" > ... - Keep trying to repro, doing random things in between. > 02:12 - Ask for the permission "2nd time" > > There were times when the frequency rate was very high. > > I was told that the 'remember' option might not be saved, since the caller > iframe is closed when the Geolocation dialog is closed. Thanks for your investigation, I have some ideas to fix this now.
Attachment #762502 - Flags: feedback?(alive) → feedback+
A simple z-index fix without gecko fix in https://bugzilla.mozilla.org/show_bug.cgi?id=852013(Bug 852013 - Send PermissionRequestEvent from mozbrowser iframe, instead of mozChromeEvent)
Attachment #763424 - Flags: review?(timdream)
Attachment #763424 - Flags: review?(timdream) → review+
1.1hd: 3e9090894daaa1c7f894a1dcc1026b21f889eadc
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap+
Does this fix make ALL permission request appear above the lockscreen? Or only the permission request which originate from the lockscreen itself (ie the geolocation prompt for lockscreen camera).
Flags: needinfo?(alive)
(In reply to Paul Theriault [:pauljt] from comment #17) > Does this fix make ALL permission request appear above the lockscreen? Or > only the permission request which originate from the lockscreen itself (ie > the geolocation prompt for lockscreen camera). NO. Not lockscreen but lockscreen-camera. See apps/system/style/zindex.css for more info.
Flags: needinfo?(alive)
Briefly, permission dialog is under lockscreen but above lockscreen camera.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: