W/ bug 829112 and bug 828838 fixed, layout/style is warning-free on my linux machine, so we should be able to mark it as FAIL_ON_WARNINGS. Filing this bug on marking it as such. Try job, to see how well this holds up across the board: https://tbpl.mozilla.org/?tree=Try&rev=626d938b64ad (There will probably be one or two MSVC warnings that we'll need to fix)

Here's the fix. (Not requesting review until we've got a green Try run)

Looks like Windows actually has a *bunch* of warnings, mostly of the form: > warning C4244: 'initializing' : conversion from 'double' to 'float', possible loss of data ...and... > warning C4305: 'initializing' : truncation from 'double' to 'const float' https://tbpl.mozilla.org/php/getParsedLog.php?id=18681700&tree=Try#error0 So, I think I'll just make this conditional on non-MSVC (as we do in lots of directories right now), and we can fix the MSVC warnings later on, if it's worth it. There's also one remaining linux warning (not sure why I didn't hit it locally), and I filed bug 829369 on that

Yeah, I'm also stuck with making gfx/ and layout/ warning-free on MSVC.

This patch excludes MSVC, per comment 2. (using the same #ifdef that we use over in the final patch on bug 824247) With bug 829369 fixed, I believe this is green on all platforms. Try run to prove it (still going, but green so far): https://tbpl.mozilla.org/?tree=Try&rev=69a0703b85dc

(sorry, that was the wrong patch -- the one for bug 829369, in fact. Here's the right patch.)

(In reply to Daniel Holbert [:dholbert] from comment #2) > There's also one remaining linux warning (not sure why I didn't hit it > locally) Because ptrdiff_t can represent all uint32_t values on 64-bits platforms, but not on 32-bits platforms?

(Yup, that's exactly it. I was initially confused because I thought it'd failed on tbpl linux64, and I was confused about why it failed there but passed on my system. But I later realized that it passed on tbpl linux64.)

Comment on attachment 700843 [details] [diff] [review] fix v2: exclude MSVC r=me, I guess. We'll see how much this breaks...

(CC'ing gps, for build-system-folks heads-up RE the upcoming moz.make switchover, since this tweaks a Makeflie)

(In reply to Daniel Holbert [:dholbert] from comment #10) > (CC'ing gps, for build-system-folks heads-up RE the upcoming moz.make > switchover, since this tweaks a Makeflie) Dealt with: https://hg.mozilla.org/users/Ms2ger_gmail.com/gps-patches/rev/776ac6087156