Closed
Bug 829210
Opened 12 years ago
Closed 12 years ago
Simplify the internal GetValueAsDate()
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: mounir, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It was as over complicated as IsValidTime(). My bad :(
Tests are passing.
Attachment #700605 -
Flags: review?(bugs)
|
Reporter | |
Updated•12 years ago
|
OS: Linux → All
Hardware: x86_64 → All
|
||
Comment 1•12 years ago
|
||
Comment on attachment 700605 [details] [diff] [review]
Patch
>+ // Now, we know where is the next '-' and what should be the size of the
>+ // string.
>+ if (aValue[endOfYearOffset+3] != '-' ||
space before and after +
>+ if (!DigitSubStringToNumber(aValue, endOfYearOffset+1, 2, aMonth) ||
space before and after +
>+ return DigitSubStringToNumber(aValue, endOfYearOffset+4, 2, aDay) &&
space before and after +
Attachment #700605 -
Flags: review?(bugs) → review+
|
|
Reporter | |
Comment 2•12 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
Target Milestone: --- → mozilla21
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•