Closed
Bug 829469
Opened 12 years ago
Closed 12 years ago
[Desktop Build] Homescreen is not swipe-able nor clickable, quick settings is not clickable
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g18+)
RESOLVED
DUPLICATE
of bug 836023
Tracking | Status | |
---|---|---|
b2g18 | + | --- |
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Keywords: regression)
With b2g18 B2G Desktop/Mac build on 10 Jan and latest Gaia, the homescreen not swipe-able; nor clickable, quick settings is not clickable
I have not look into the cause yet, however this will block the Firefox App Day event given the fact that people basically will not be able to launch app.
The latest OS Simulator dates 26 Dec, and is not affect by this bug (yet).
I suspect it was because bug 823619 but I was wrong, commit 97cdcec still works. Need a regression window and a fix.
Comment 1•12 years ago
|
||
That's because all the mouse events are discarded, please check the following codes in the shared/js/mouse_event_shim.js:
// Use capturing listeners to discard all mouse events from gecko
window.addEventListener('mousedown', discardEvent, true);
window.addEventListener('mouseup', discardEvent, true);
window.addEventListener('mousemove', discardEvent, true);
window.addEventListener('click', discardEvent, true);
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Pin Zhang [:pzhang] from comment #1)
> That's because all the mouse events are discarded, please check the
> following codes in the shared/js/mouse_event_shim.js:
> // Use capturing listeners to discard all mouse events from gecko
> window.addEventListener('mousedown', discardEvent, true);
> window.addEventListener('mouseup', discardEvent, true);
> window.addEventListener('mousemove', discardEvent, true);
> window.addEventListener('click', discardEvent, true);
Yeah you are right, commit 0a66aae is broken and commit 97cdcec works.
But Quick Settings still works in commit 0a66aae though. Could be separate issues.
djf, what do you think wd could fix this w/o breaking the phone?
We specifically tested desktop builds with the shim. It doesn't even attempt to hook mouse events when touch events aren't available. (I wrote that patch! ;) )
Something (else) might have regressed this though.
Comment 4•12 years ago
|
||
The "doesn't event attempt" code that Chris is referring to is this in mouse_event_shim.js:
// Bail if we're not on running on a platform that sends touch
// events. We don't need the shim code for mouse events.
try {
document.createEvent('TouchEvent');
} catch (e) {
return;
}
When 823619 landed, that code executed the return on desktop. If that has changed for some reason, then it is the shim that is eating events and breaking things, and we'll need another way to distinguish the desktop case.
Flags: needinfo?(dflanagan)
Assignee | ||
Comment 5•12 years ago
|
||
http://mxr.mozilla.org/mozilla-beta/source/b2g/app/b2g.js#289
Thanks for the info. I thought we still have touch events turned on on B2G Desktop...
Assignee | ||
Comment 6•12 years ago
|
||
Taking, so I would remember to investigate further.
Assignee: nobody → timdream+bugs
tracking-b2g18:
--- → ?
Forcing a return in mouse_event_shim.js (rather than relying on the touch event exception) does not fix the issue for me.
Comment 9•12 years ago
|
||
Homescreen no longer uses the shim. I has been ported to use touch events.
So if it is broken it is because we don't have touch events on the desktop!
Updated•12 years ago
|
Comment 10•12 years ago
|
||
I have added mouse support to homescreen
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•