Jim Mathies [:jimm] Assignee
	Description • 12 years ago

This will have to be done in FrameworkView's OnWindowSizeChanged. We can cache the view state and check to see if it's changed, then fire an appropriate observer.

	Jim Mathies [:jimm] Assignee
	Comment 1 • 12 years ago

This won't fire on start up but will fire for changes. So front end script will have to query for the start up value when it initializes.

	Brian R. Bondy [:bbondy]
	Comment 2 • 12 years ago

Comment on attachment 701240 [details] [diff] [review]
patch

Review of attachment 701240 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/winrt/FrameworkView.cpp
@@ +385,5 @@
> +FrameworkView::FireViewStateObservers()
> +{
> +  ApplicationViewState state;
> +  MetroUtils::GetViewState(state);
> +  if (state == mViewState) {

nit: add a comment that says only fire when we have a new view state.

	Matt Brubeck (:mbrubeck)
	Comment 3 • 12 years ago

Comment on attachment 701240 [details] [diff] [review]
patch

Drive-by feedback: Can we use a single notification subject (like "metro_viewstate_changed"), so that observers only need to subscribe once?  Then they can use MetroUtils.snappedState to see what the new state is, and/or you can pass it as the "data" parameter to NotifyObservers.

	Jim Mathies [:jimm] Assignee
	Comment 4 • 12 years ago

(In reply to Matt Brubeck (:mbrubeck) from comment #3)
> Comment on attachment 701240 [details] [diff] [review]
> patch
> 
> Drive-by feedback: Can we use a single notification subject (like
> "metro_viewstate_changed"), so that observers only need to subscribe once? 
> Then they can use MetroUtils.snappedState to see what the new state is,
> and/or you can pass it as the "data" parameter to NotifyObservers.

great idea, will update.

	Jim Mathies [:jimm] Assignee
	Comment 6 • 12 years ago

http://hg.mozilla.org/projects/elm/rev/8131bf55cc78

	Jim Mathies [:jimm] Assignee
	Comment 7 • 12 years ago

minor call ordering fix up - 

https://hg.mozilla.org/projects/elm/rev/675ee8600930