Closed Bug 82984 Opened 23 years ago Closed 23 years ago

Pref for "Compact folders when it will save over 100 kb" is not remembered

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: Peter, Assigned: dianesun)

References

Details

(Whiteboard: [PDT+] Request R&SR)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9+) Gecko/20010527 Pref for "Compact folders when it will save over 100 kb" is not remembered When i set the above pref for my newsgroups, the checkbox is not retained upon return to the pref.
cc'ing stephen because he may be involved with fixing this.
Stephen, could you add diane sun to the CC of this bug? I don't know her email address.
Reassigning to Diane, cc'ing interested parties. Also, the actual compaction code is not written - that's bug 17204. This bug is for making sure the pref gets remembered.
Assignee: sspitzer → dianesun
QA Contact: esther → gchan
This preference is actually moved to preference dialog. See bug 79554 *** This bug has been marked as a duplicate of 79554 ***
Status: UNCONFIRMED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
NO, it's not a dupe. The other bug is about differentiating between compaction settings for *different accounts". This bug is about remembering the setting at all. reopening.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Changing status to New. I see this in the current branch build 2001-06-07-13-0.9.1/ on Windows nt 4.0 Hopefully bug will be fixed (ie pref will be remembered) as result of the new implementation of the pref in bug 79554.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.2
This was due to the changes in am-offline.xul version 1.2. There are two duplicate ids with the same name for imap and nntp which caused the preference not saved. The same with "Do not download message locally that are larger than "
PDT+ per 6/12 mtg.
Whiteboard: [PDT+]
Attached patch Fix for preference (deleted) — Splinter Review
Whiteboard: [PDT+] → [PDT+] Request R&SR
This preference has been moved the global pref space : Edit -> Preference ->Offline and Disk Space. And it will not be affacted by the two ids with the same name but for IMAP, POP seperately in am-offline.xul ver 1.2
I'm confused. I don't see offlineCompactFolder or offlineCompactFolderMin elements in pref-offline.xul
So, the master patch is in bug 79554 (infact includes this patch too). Get'em in. r=bhuvan
I agree..it's little bit confusing until you trace to the patch in the bug 79554. Diane, Please post patch(es) in the entirety in the future. thanks. bhuvan
in the future, if you've got a bug with the "master" patch, there is no need to re-attach the same patch to other bugs. (just indicate where the real patch lives.) I've made comments to #79554, but those comments do not apply to this part of the patch. trusting bhuvan's review, sr=sspitzer
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Blocks: 83989
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Commercial builds 2001-06-21-09-trunk/ WinNT 4.0 2001-06-21-11-trunk/ Linux 2.2, red hat 7.0 2001-06-21-08-trunk/ MAC 9.0.4 Note: Compact Folders pref was moved from an individual account basis to the Global pref section: Edit|Preferences| Offline & Disk Space See Bug 79554. Note: Compact folders back end code is not implemented yet: bug 17204 Verified that the compact folders pref can be edited and/or saved. Tried testing it in various windows (Browser, Composer, Messenger, etc..) and it works fine. Marking as Verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: