Build: B2G 18 1/12/2013 Device: Unagi Steps: 1. Go to http://mozqa.com/webapi-permissions-tests/ 2. Install "Packaged App Test Case 3" - mini-manifest below: { "name" : "Test WebAPI Permissions", "version" : "1.1", "size" : 10000000000000000000000000000000000000000000000000000000000000000, "release_notes": "First v1.1 release", "icons": { "126": "/webapi-permissions-tests/qalogo.png" }, "developer": { "name": "Mozilla QA", "url": "http://jasondanielsmith.wordpress.com/" }, "package_path": "/webapi-permissions-tests/webpackagedappwithperms.zip" } Expected: The app should fail to install with the insufficient error thrown before even the download begins, as we already know the size of the app is larger than the size of the phone. Actual: App will still move to install and successfully installs. Note in this test case, the packaged app size is actually in reality is 17 KB, but that's intentional that the "size" field is different than the packaged app size - I'm aiming to test that we are checking the size field to determine if we throw insufficient space successfully. This is a regression - this was working a couple of days ago.

For some reason we are getting the stat() result anymore at [1] and [2]. Doug, Gregor, any idea of what might have changed? [1] https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#2088 [2] https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/FreeSpaceWatcher.jsm#47

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #1) > For some reason we are getting the stat() result anymore at [1] and [2]. s/are getting/are *not* getting/

Could be a device-storage permission problem but I am not aware of any changes in the last few days. In order to access stat you need at least the "device-storage:apps":{ "access": "readonly" }, access. https://mxr.mozilla.org/gaia/source/apps/settings/manifest.webapp#16 shows that only the settings and feedback app has this permission. (I haven't used mxr for gaia before. I hope it doesn't use some outdated code.) Could you check again that all involved apps have the right permission? Maybe you should split up the onsuccess and onerror functions and try to get more information.

Thanks Gregor! (In reply to Gregor Wagner [:gwagner] from comment #3) > Could be a device-storage permission problem but I am not aware of any > changes in the last few days. In order to access stat you need at least the > "device-storage:apps":{ "access": "readonly" }, access. > https://mxr.mozilla.org/gaia/source/apps/settings/manifest.webapp#16 shows > that only the settings and feedback app has this permission. (I haven't used > mxr for gaia before. I hope it doesn't use some outdated code.) > Please, correct me if I am wrong, but I think there is no need for device-storage permissions in this case. Note that the one (https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#2086) asking for device storage is not a Gaia app but the shell window https://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.xul#9. Am I wrong? > Could you check again that all involved apps have the right permission? > Maybe you should split up the onsuccess and onerror functions and try to get > more information. I'll do that. Thanks.

I am getting 'SecurityError' in the DOMRequest.onerror callback: "I/Gecko ( 493): -*-*- Webapps.jsm : error SecurityError" So I guess you were right! It might be a permissions problem. I wonder what have changed recently.

The stat() request is failing in: b2g/components/ContentPermissionPrompt.js Here: handledByApp: function handledByApp(request) { if (request.principal.appId == Ci.nsIScriptSecurityManager.NO_APP_ID || request.principal.appId == Ci.nsIScriptSecurityManager.UNKNOWN_APP_ID) { // This should not really happen request.cancel(); return true; }

I am not totally familiar with this code, but if the installer is using device storage, it probably is running with the system principal. And if so, this check is going to be wrong. Shouldn't we have a test like: handledByApp: function handledByApp(request) { if (secMan.isSystemPrincipal(request.principal)) { request.allow(); return true; } ....

I think we need that, yes.

I confirm that this fixes the issue. I modified my test app at http://people.mozilla.org/~fdesre/updates/ to ask for 100GB of space, and got the "Not enough space" dialog.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/805f7deba66b marking fixed per jst rules.

lgtm on 1/18 build.

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.