Closed
Bug 830033
Opened 12 years ago
Closed 12 years ago
If an update is found available with the update notification present, we need to notify the user of how many *new* updates are available now
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jsmith, Assigned: mbudzynski)
References
Details
Attachments
(1 file)
Right now, if a user actively has a notification in their notification bar for updates being available, and then we find a new update from a manual or automatic sync, the update notification will change, but the user will not be notified that there was a change in the number of updates that typically shows up (the drop-down that appears saying "3 updates available" on the status bar). Minor nit - but it would be helpful to be clear to notify immediately if we find a brand new update in the list.
Reporter | ||
Updated•12 years ago
|
Blocks: b2g-app-updates
Comment 1•12 years ago
|
||
for me it's at least related, if not dupe, to Bug 824369
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mbudzynski
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #704866 -
Flags: review?(felash)
Comment 3•12 years ago
|
||
Comment on attachment 704866 [details]
patch
comments added on the pull request.
Please request a new review when you fixed this :)
Sorry for the long time before the review !
Attachment #704866 -
Flags: review?(felash)
Assignee | ||
Updated•12 years ago
|
Attachment #704866 -
Flags: review?(felash)
Assignee | ||
Comment 4•12 years ago
|
||
fixed, please review again.
Comment 5•12 years ago
|
||
Comment on attachment 704866 [details]
patch
r=me with the last nit addressed
Attachment #704866 -
Flags: review?(felash) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•12 years ago
|
||
Should we try to get approval on this for v1.01?
Comment 8•12 years ago
|
||
For me this is definitely not a blocker, but this can lead to incomprehension and the patch is small.
However if this needs to land to 1.01 I'd like a superreview from etienne :-)
Reporter | ||
Comment 9•12 years ago
|
||
Whether it's a blocker or not doesn't really affect whether you ask for approval. Approval is asked for when you it's a low risk patch with some value to take into a branch. If it's low risk, we should ask for approval. But if additional review is needed first, I'd ask for an additional review then.
Comment 10•12 years ago
|
||
As a rule of thumb, I'll try to have an additional review for whatever will land in a branch. For now it's only a personal rule of thumb :)
Comment 11•12 years ago
|
||
Comment on attachment 704866 [details]
patch
etienne, wanna do a superreview on this ?
Attachment #704866 -
Flags: superreview?(etienne)
Comment 13•12 years ago
|
||
Comment on attachment 704866 [details]
patch
I'm flattered but I don't think that's what supperreviews are for :)
(That said the code looked good, minus the linting errors...)
Attachment #704866 -
Flags: superreview?(etienne)
You need to log in
before you can comment on or make changes to this bug.
Description
•