Closed Bug 830111 Opened 12 years ago Closed 12 years ago

[Settings] - arrange Phone lock screen

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 affected)

Status:
RESOLVED DUPLICATE of bug 847552
Tracking Flags:
Tracking Status
b2g18 --- affected

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

(Whiteboard: interaction, uxbranch, landed in uxbranch)

Attachments

(2 files, 1 obsolete file)

patch for UX branch
(deleted), text/html
kaze
: review+
vingtetun
: approval-gaia-v1+
Details
Before-After
(deleted), image/png
Details
No description provided.
Attached file patch for Gaia repo (obsolete) (deleted) —
Attachment #701579 - Flags: review?(kaze)
Comment on attachment 701579 [details] patch for Gaia repo move to UX branch
Attachment #701579 - Attachment is obsolete: true
Attachment #701579 - Flags: review?(kaze)
Attached file patch for UX branch (deleted) —
Attachment #701586 - Flags: review?(kaze)
Pavel: for the record, would you please attach two screenshots? (before/after your patch)
Attached image Before-After (deleted) —
Sure :) when we habe error message I remove the Button ("Change") from the header because this cause problems
Attachment #701586 - Flags: review?(kaze) → review+
Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/05c1026284406ee83fbfa504a32344c1c3e39b8f
Whiteboard: interaction → interaction, uxbranch, landed in uxbranch
I like the spacing at the top... having the error message appear then having to go back and then forward to retype the the passcodes again seems a bit ui unfriendly.
(In reply to Naoki Hirata :nhirata from comment #7) I agree with Naoki, but it's better than before, because before this patch the error message appeared before the fields, and they moved it down under Keyboard and I need someone to help us with UX
Flags: needinfo?(padamczyk)
Can you merge this into the UX branch.
Flags: needinfo?(padamczyk)
it is already landed to UX branch
https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 701586 [details] patch for UX branch Master commit hash is 1f919f1 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): Not match UX spec. User impact if declined: Polishing Passcode Panel Testing completed: Yes Risk to taking this patch (and alternatives if risky): Only polishing stuff. String or UUID changes made by this patch:
Attachment #701586 - Flags: approval-gaia-v1?(21)
Comment on attachment 701586 [details] patch for UX branch This comes from the UX branch process where QA has already checked that it works. a=me.
Attachment #701586 - Flags: approval-gaia-v1?(21) → approval-gaia-v1+
Not sure bug 855107 is the outcome of this patch. Can you please check Pavel?
Flags: needinfo?(pivanov)
Flags: needinfo?(pivanov)
Resolution: FIXED → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: