All that we need for RILContentHelper is actually something implements nsIDOMMozMobileICCInfo.

Comment on attachment 703185 [details] [diff] [review] Part 4: Update GPS Hi, Doug This bug is about to change some IDL in nsIRadioInterfaceLayer, so there will be also some changes in GPS, Could you review this for me? thanks

Removed empty white spaces and updated SmsDatabaseService

I found I didn't update the bug comment correctly.

Comment on attachment 703186 [details] [diff] [review] Part 5: update lastKnownMcc. Review of attachment 703186 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/RadioInterfaceLayer.js @@ +1629,5 @@ > + > + if (message.mcc) { > + message['lastKnownMcc'] = message.mcc; > + try { > + Services.prefs.setIntPref("ril.lastKnownMcc", message.mcc); Please set pref only when it changes.

add r=dougt

As I've discussed with Gregor, lastKnownMcc should be in nsIDOMMozMobileNetworkInfo, instead of nsIDOMMozMobileICCInfo. So I will remove the lastKnownMcc code in Part 5.

rebase

rebase and remove lastKnownMcc

Hi, Vicamo I r? again for lastKnownMcc should be in network info instead of icc info, I'll file another bug for that. So in this patch I remove related code to lastKnownMcc.

Try run for 427081dd9a96 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=427081dd9a96 Results (out of 326 total builds): success: 308 warnings: 15 failure: 3 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-427081dd9a96

Bug 833908 requests the same thing and claims to block bug 808607.

Vicamo, yes this bug fixes the issue reported in bug 833908 but we have a concern that this bug has a lot more impact so close to v1 release. Wondering if you could reconsider fixing bug 833908.

(In reply to Anshul from comment #19) > Vicamo, yes this bug fixes the issue reported in bug 833908 but > we have a concern that this bug has a lot more impact so close > to v1 release. Wondering if you could reconsider fixing > bug 833908. No problem.

I'll wait for Bug 833908 is landed then rebase and commit.

Comment on attachment 705265 [details] [diff] [review] Part 5: remove lastKnownMcc. v3 I move this patch to Bug 833711.

Add RILContentHelper changes.

rebase

Try run for 1c51d756b861 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=1c51d756b861 Results (out of 241 total builds): exception: 48 success: 44 failure: 149 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-1c51d756b861

I interrupted try server, so I got so many failures in comment 26. The latest result is from https://tbpl.mozilla.org/?tree=Try&rev=85e0b813e27a, However there's still one xpcshell failure, will address that in Part 6 Patch.

To fix xpcshell tests.

Try run for 1a36de801182 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=1a36de801182 Results (out of 331 total builds): success: 313 warnings: 16 failure: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-1a36de801182

rebase

rebase

rebase

rebase

rebase

rebase

try https://tbpl.mozilla.org/?tree=Try&rev=86f0f1e49c8a

https://hg.mozilla.org/integration/mozilla-inbound/rev/aad75c7c49c5 https://hg.mozilla.org/integration/mozilla-inbound/rev/7771dd6d21c5 https://hg.mozilla.org/integration/mozilla-inbound/rev/96941ab98a21 https://hg.mozilla.org/integration/mozilla-inbound/rev/a2f1b15eecd1 https://hg.mozilla.org/integration/mozilla-inbound/rev/fce1df0cec5c https://hg.mozilla.org/integration/mozilla-inbound/rev/2addf5bd1730

Try run for 86f0f1e49c8a is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=86f0f1e49c8a Results (out of 328 total builds): success: 313 warnings: 14 failure: 1 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-86f0f1e49c8a

This seems to have broken marionette tests: https://tbpl.mozilla.org/php/getParsedLog.php?id=19196088&tree=Mozilla-Inbound&full=1

Sorry for that. In the try run, I saw the follow message "Bug 825722 - Intermittent end-of-year timebomb in test_incoming.js: TEST-UNEXPECTED-FAIL | false was false, expected true | got false, expected true Bug 760199 - test_incoming.js: TEST-UNEXPECTED-FAIL | got false, expected true 00:11:17 ERROR .... Bug 832662 - Intermittent test_outgoing_delete.js | TimeoutException: socket.timeout Only displaying first 20 of 100+ failures - View log." I saw Bug ID on it, and I though that's caused by other bugs. I'll test again.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/18b2fd105563

Try run for e156384cb584 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=e156384cb584 Results (out of 2 total builds): success: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-e156384cb584

Try run for f49ceb92685c is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=f49ceb92685c Results (out of 2 total builds): success: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-f49ceb92685c

Try run for dc272059c514 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=dc272059c514 Results (out of 2 total builds): success: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-dc272059c514

Try run for 2f365d15e8c8 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=2f365d15e8c8 Results (out of 2 total builds): success: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-2f365d15e8c8

Try run for a405cd93c384 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=a405cd93c384 Results (out of 333 total builds): exception: 1 success: 322 warnings: 8 failure: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/yhuang@mozilla.com-a405cd93c384

Comment on attachment 706962 [details] [diff] [review] Part 2: rename icc to iccInfo v5 Review of attachment 706962 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/sms/src/ril/SmsDatabaseService.js @@ +771,5 @@ > if (sender === undefined || sender === "undefined") { > sender = null; > } > > let receiver = aReceiver; In this line below I didn't rename icc to iccInfo. Will address that in next patch. ::: dom/system/gonk/RadioInterfaceLayer.js @@ +214,5 @@ > > this.rilContext = { > radioState: RIL.GECKO_RADIOSTATE_UNAVAILABLE, > cardState: RIL.GECKO_CARDSTATE_UNAVAILABLE, > + imsi: null, I'll move imsi to part 3.

Comment on attachment 706964 [details] [diff] [review] Part 4: Update GPS v2 Review of attachment 706964 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/GonkGPSGeolocationProvider.cpp @@ +418,5 @@ > + rilCtx->GetImsi(id); > + } > + > + if (flags & AGPS_RIL_REQUEST_SETID_MSISDN) { > + nsCOMPtr<nsIDOMMozMobileICCInfo> icc; To make naming consistent, I'll rename this to iccInfo as well.

rebase

update SmsDatabaseService, and move imsi in RadioInterfaceLayer.js to part 3.

rebase

rename icc to iccInfo

rebase

rebase

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1decce80087 https://hg.mozilla.org/integration/mozilla-inbound/rev/05bbd6799b5a https://hg.mozilla.org/integration/mozilla-inbound/rev/baf4dd1d44db https://hg.mozilla.org/integration/mozilla-inbound/rev/bf3fc973a6ea https://hg.mozilla.org/integration/mozilla-inbound/rev/9f66f8a00cd0 https://hg.mozilla.org/integration/mozilla-inbound/rev/6fec3ed8b9a2

https://hg.mozilla.org/mozilla-central/rev/d1decce80087 https://hg.mozilla.org/mozilla-central/rev/05bbd6799b5a https://hg.mozilla.org/mozilla-central/rev/baf4dd1d44db https://hg.mozilla.org/mozilla-central/rev/bf3fc973a6ea https://hg.mozilla.org/mozilla-central/rev/9f66f8a00cd0 https://hg.mozilla.org/mozilla-central/rev/6fec3ed8b9a2