Enabling rooting analysis by setting the JS_GC_ZEAL environment variable breaks any tests that attempt to set the GC zeal setting, as the environment variable takes precedence. Currently this is only gc/incremental-state.js.

The fix is to add a test metaline that disables the test if the environment variable is set.

Instead of ignoring the test, allow use of gczeal() to override that set by the environment. Tidy the initialization of zeal mode so that it happens inside js_InitGC(). Perform more sanity checking on the zeal value set from the environment variable. Fix an assertion failure if js_InitGC() fails. Fix a rooting bug in GlobalObject exposed by turning on rooting analysis sooner.

Comment on attachment 702285 [details] [diff] [review] Better fix Review of attachment 702285 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsgc.cpp @@ +907,5 @@ > + return true; > + > + int zeal = -1; > + int frequency = JS_DEFAULT_ZEAL_FREQ; > + if (strcmp(env, "help")) { Could you add a != 0 at the end here?

(In reply to Bill McCloskey (:billm) from comment #4) Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/9b83a5ada45f