Closed Bug 830380 Opened 12 years ago Closed 12 years ago

[FTU UX VD] Tutorial. Replace the third image

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: vicky, Assigned: fcampo)

Details

(Whiteboard: visual design, UX P2, uxbranch, landed in uxbranch, visual)

Attachments

(4 files)

The image to replace the existing
(deleted), image/png
Details
Homescreen X
(deleted), image/png
Details
Image number 3 of the current tutorial.
(deleted), image/png
Details
Link to commit https://github.com/mozilla-b2g/gaia/commit/c82863e
(deleted), text/html
akeybl
: approval-gaia-v1+
Details
Attached image The image to replace the existing (deleted) —
Replace the third step image for the one attached.
Assignee: nobody → fernando.campo
Whiteboard: visual design, UX P2
Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/f06b416db6e99739af33e0524028c023bc25a3de
Whiteboard: visual design, UX P2 → visual design, UX P2, uxbranch, landed in uxbranch
The position of the delete "x" should be updated to upper left like on the device.
Flags: needinfo?(vpg)
Whiteboard: visual design, UX P2, uxbranch, landed in uxbranch → visual design, UX P2, uxbranch, landed in uxbranch, visual
I think patryk is right... the x isn't in the right spot...
Attached image Homescreen X (deleted) —
Can you please match the alignment of the FRE to that of the homescreen.
Vicky, can you attach the updated graphics and send it to sam for integration. Thanks!
Assignee: fernando.campo → vpg
Flags: needinfo?(vpg)
Attached the asset to replace the current 3rd image with updated delete "x" positioning.
The new change of image is on PR https://github.com/gordonbrander/gaia/pull/130
Assignee: vpg → fernando.campo
Hi Fernando or Sam, after the Pull Request corresponding revision can you land the patch in master? As there is no clear answers about the UX branch purpose right now, it'd be better to land it in master so after that, we can ask for uplifting the patch to v1-train. Otherwise I am afraid the work done will be lost and it will not land in time or never in the commercial release v1.1.
Revert last commit in ux branch. Landed new commit in uxbranch: https://github.com/gordonbrander/gaia/commit/ed7ce996aef66a243776aefcb57b6148679dae2d
https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified on Master Master build : 2013-03-26-07-02-04 "mozilla-central" revision="28b048ffb7a7" "integration/gaia-central" revision="44f6a17f24d4" "gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151" "gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"
Status: RESOLVED → VERIFIED
status-b2g18: --- → affected
Fernando or Sam: Is this ready to raise to approval? with user value and risk in the comments?
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: The user will see differences on icons between images on tutorial Testing completed: Risk to taking this patch (and alternatives if risky): Low risk, only asset changes String or UUID changes made by this patch:
Attachment #732322 - Flags: approval-gaia-v1?
Thanks Fernando - appreciate it!
Master commit is c82863e
Attachment #732322 - Flags: approval-gaia-v1? → approval-gaia-v1+
Uplifted commit c82863e22735fcd609aa98dc091a8f1eabbf18f0 as: v1-train: ab090dbd6f68ccf4c88513e6a476787697bdcb59
status-b2g18: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: