Closed
Bug 830684
Opened 12 years ago
Closed 11 years ago
Sidebar toolbox height is 1px higher than the breadcrumbs on mac
Categories
(DevTools :: Framework, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: paul, Assigned: paul)
References
Details
Attachments
(5 files, 1 obsolete file)
screenshot of the 1px difference
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #2)
> What version of osx do you have?
I've seen this happening sometimes on my machine (Mountain Lion), but not always.
|
|
Assignee | |
Comment 5•12 years ago
|
||
Heather, can you attach a screenshot please?
Flags: needinfo?(fayearthur)
|
|
Assignee | |
Updated•12 years ago
|
Blocks: DevToolsPaperCuts
|
|
Assignee | |
Comment 7•12 years ago
|
||
(In reply to Heather Arthur [:harth] from comment #6)
> Created attachment 705210 [details]
> screenshot of the 1px difference
>
> Here's a screenshot of it.
Can I ask to take a screenshot of the whole toolbox (I want to compare the font size).
|
||
Comment 8•12 years ago
|
||
Far worse on Fedora (Gnome 3)
|
|
Assignee | |
Updated•12 years ago
|
Priority: -- → P2
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → paul
|
|
||
Comment 10•12 years ago
|
||
It seems that toolbar height vs. sidebar tabs height is completely and randomly different on each platform.
|
|
||
Comment 11•12 years ago
|
||
I suspect that it is related to font-size / line heights.
|
|
Assignee | |
Comment 12•11 years ago
|
||
This should make the whole thing font-size agnostic (I needed to replicated the min-height of the button in the breadcrumbs).
Not tested on Windows and mac.
Attachment #770767 -
Flags: feedback?(scrapmachines)
|
|
Assignee | |
Comment 13•11 years ago
|
||
Attachment #770767 -
Attachment is obsolete: true
Attachment #770767 -
Flags: feedback?(scrapmachines)
Attachment #770768 -
Flags: feedback?(scrapmachines)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #770768 -
Flags: review?(vporof)
|
|
||
Comment 14•11 years ago
|
||
Comment on attachment 770768 [details] [diff] [review]
Patch v1 (fixed typo)
Review of attachment 770768 [details] [diff] [review]:
-----------------------------------------------------------------
I don't have any reason to not r+ this, but I'm little worried that this will not definitively fix the problem. See my questions below.
::: browser/themes/linux/devtools/common.css
@@ +281,4 @@
> -moz-padding-start: 6px;
> margin: 0;
> min-width: 78px;
> + min-height: 32px;
Is the sister container (the toolbar with breadcrumbs in the inspector and debugger) always guaranteed to be higher than 32px? I'm trying to understand why you added a min-height here.
Also, what happens if the toolbar doesn't contain a button? In that case, it doesn't sound like its height will match the sidebar tabs height (this used to be the case with the network monitor for a while).
Attachment #770768 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 15•11 years ago
|
||
The other toolbars have a guaranteed min-height.
> Also, what happens if the toolbar doesn't contain a button?
I don't know.
Whiteboard: [land-in-fx-team]
|
|
||
Comment 16•11 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #15)
> The other toolbars have a guaranteed min-height.
>
How? Might want to explain that in the CSS.
|
|
Assignee | |
Comment 17•11 years ago
|
||
+comments
|
|
||
Comment 18•11 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 19•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
|
||
Comment 20•11 years ago
|
||
Comment on attachment 770768 [details] [diff] [review]
Patch v1 (fixed typo)
patch is already in production.
Attachment #770768 -
Flags: feedback?(scrapmachines) → feedback+
|
||
Updated•11 years ago
|
No longer blocks: DevToolsPaperCuts
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•