Closed Bug 830696 Opened 12 years ago Closed 12 years ago

B2G STK: provide more information about STK_CMD_SET_UP_CALL to gaia

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(2 files, 3 obsolete files)

According to 3GPP TS 11.14, section 12.6, the command qualifier can indicate the following: SET UP CALL: '00' = set up call, but only if not currently busy on another call; '01' = set up call, but only if not currently busy on another call, with redial; '02' = set up call, putting all other calls (if any) on hold; '03' = set up call, putting all other calls (if any) on hold, with redial; '04' = set up call, disconnecting all other calls (if any); '05' = set up call, disconnecting all other calls (if any), with redial; '06' to 'FF' = reserved values. We shall provide this information to gaia.
Attached patch Part 1: IDL for SET_UP_CALL, v1 (deleted) — Splinter Review
IDL patch
RIL implementation
Attached patch Part 3: xpcshell tests for SET_UP_CALL, v1 (obsolete) (deleted) — Splinter Review
xpcshell tests
Attached patch Part 4: marionette tests for SET_UP_CALL, v1 (obsolete) (deleted) — Splinter Review
marionette tests
Attachment #702679 - Flags: superreview?(jonas)
Attachment #702679 - Flags: review?(allstars.chh)
Attachment #702680 - Flags: review?(allstars.chh)
Attachment #702681 - Flags: review?(allstars.chh)
Attachment #702682 - Flags: review?(allstars.chh)
Hi Carol, From the comment of RIL_REQUEST_STK_HANDLE_CALL_SETUP_REQUESTED_FROM_SIM in hardware/ril/include/telephony/ril.h [1] 'When STK application gets RIL_UNSOL_STK_CALL_SETUP, the call actually has been initialized by ME already. (We could see the call has been in the 'call list') So, STK application needs to accept/reject the call according as user operations.' It seems gaia only needs to pass user confirmation to gecko, then gecko reports to modem by 'RIL_REQUEST_STK_HANDLE_CALL_SETUP_REQUESTED_FROM_SIM'. Actually the implementation of Android is the same. So I think the action of comment #0 shall be handled by modem or proprietary. Could you help to confirm about this? If anything wrong, please correct me. :) Thanks [1] https://github.com/EdgarChen/platform_hardware_ril/blob/master/include/telephony/ril.h#L2531
The callMessage will be fixed in bug 831183.
Attachment #702680 - Attachment is obsolete: true
Attachment #702681 - Attachment is obsolete: true
Attachment #702682 - Attachment is obsolete: true
Attachment #702680 - Flags: review?(allstars.chh)
Attachment #702681 - Flags: review?(allstars.chh)
Attachment #702682 - Flags: review?(allstars.chh)
Comment on attachment 702679 [details] [diff] [review] Part 1: IDL for SET_UP_CALL, v1 Wait feedback (comment #5). So, cancel review first.
Attachment #702679 - Flags: superreview?(jonas)
Attachment #702679 - Flags: review?(allstars.chh)
This blocks something which is tef+ which in turn blocks bug 808607.
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+
Flags: needinfo?(cyang)
if cyang is not available, could anshulj or mvines confirm comment 5?
Flags: needinfo?(mvines)
Flags: needinfo?(anshulj)
Edgar, you are right that Gaia doesn't need to handle the command qualifiers. We have confirmed the same with Android. You can close this bug.
blocking-b2g: tef+ → ---
Flags: needinfo?(mvines)
Flags: needinfo?(cyang)
Flags: needinfo?(anshulj)
As modem can handle this, I close this as WONTFIX.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: