Open
Bug 830718
Opened 12 years ago
Updated 2 years ago
Reenable private browsing notification xpcshell tests
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
NEW
People
(Reporter: jdm, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
Now that the notification is synchronous with docshells being destroyed, as opposed to requiring garbage collection, we should be able to reenable these tests that would frequently time out.
test_pb_notification.js
test_pb_notification_ipc.js
|
||
Updated•12 years ago
|
Blocks: pbngentest
|
|
||
Comment 1•12 years ago
|
||
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 706250 [details] [diff] [review]
Patch (v1)
Review of attachment 706250 [details] [diff] [review]:
-----------------------------------------------------------------
The patch is fine, but the try run shows that the IPC test times out. I'll look into it.
Attachment #706250 -
Flags: review?(josh) → review+
|
|
Reporter | |
Updated•12 years ago
|
Flags: needinfo?(josh)
|
|
||
Comment 3•12 years ago
|
||
Any updates here, Josh?
|
|
||
Updated•12 years ago
|
Assignee: ehsan → josh
|
|
Reporter | |
Comment 4•11 years ago
|
||
Looking at the results again, now that xpcshell tests that time out show the rest of the log.
https://tbpl.mozilla.org/?tree=Try&rev=56a06b64e67f
Flags: needinfo?(josh)
|
|
Reporter | |
Comment 5•11 years ago
|
||
OS X timed out. I wonder if there's something about the hidden window...
https://tbpl.mozilla.org/?tree=Try&rev=44ae10d4b2c7
|
|
Reporter | |
Updated•6 years ago
|
Assignee: josh → nobody
Status: ASSIGNED → NEW
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•