Closed
Bug 830855
Opened 12 years ago
Closed 12 years ago
Remove JSScript::principals
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: bholley, Assigned: billm)
Details
Attachments
(1 file)
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
It's not clear to me how this could ever be anything sane except the compartment principals. I think we should remove it, unless anyone knows something that I don't.
We probably need to keep originPrincipals for now, though.
Comment 1•12 years ago
|
||
Sounds good. Perhaps we can assert, on script creation, that whatever principle was passed is equivalent to compartment->principle?
Assignee | ||
Comment 2•12 years ago
|
||
This is a pretty conservative patch. Once we've given the assertions some time, we'll be able to remove more code.
I left the field in as padding, but I'm planning to use it for zones pretty soon.
https://tbpl.mozilla.org/?tree=Try&rev=d9ddc605aa59
Assignee: bobbyholley+bmo → wmccloskey
Status: NEW → ASSIGNED
Attachment #706184 -
Flags: review?(luke)
Updated•12 years ago
|
Attachment #706184 -
Flags: review?(luke) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•