Closed Bug 830901 Opened 12 years ago Closed 12 years ago

[App Updates] Disabling all checkboxes in the update prompt, hitting later, and return prompt - checkboxes are enabled, but download button is disabled

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18- verified)

Status:
VERIFIED FIXED
Milestone:
1.1 QE1 (5may)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 - verified

People

(Reporter: jsmith, Assigned: leo.bugzilla.gaia)

References

Details

(Whiteboard: [TD-8923] [QE1])

Attachments

(1 file)

Pull request url
(deleted), text/html
julienw
: review+
Details
Build: B2G 18 1/15/2013 Device: Unagi Steps: 1. Find an app update on your device 2. Select the update prompt 3. Uncheck each checkbox for each app 4. Hit "Later" 5. Select the update prompt again Expected: The checkboxes should be enabled and the download button should be enabled. Actual: The checkboxes are enabled, download button is disabled. Easy to work-around, but an annoying inconsistency.
Blocks: b2g-app-updates
tracking-b2g18: --- → ?
Patches welcome, but this isn't likely to draw much attention over other work in v1.
tracking-b2g18: ? → -
Wayne, would you apply leo+ to this bug, since the Bug 858354 has been resolved-duplicate.
Flags: needinfo?(wchang)
Whiteboard: TD-8923
(In reply to leo.bugzilla.gaia from comment #3) > Wayne, would you apply leo+ to this bug, since the Bug 858354 has been > resolved-duplicate. I'll nom first per your request. FWIW, we didn't block nor track this originally, because the workaround here is simple. It's awkward, though.
blocking-b2g: --- → leo?
Flags: needinfo?(wchang)
Hi Jason, The fix is real simple, just adding updateDownloadButton() call at the end of showDownloadPrompt function in update_manager.js I'm making the pull request now, hopefully this patch can be pushed in. Thanks
Attached file Pull request url (deleted) —
Assignee: nobody → leo.bugzilla.gaia
Attachment #737330 - Flags: review?(timdream)
Attachment #737330 - Attachment mime type: text/plain → text/html
Please add an unit test for this case. The update functionality has a quite comprehensive suite and I'd like to keep it this way. Thanks !
Comment on attachment 737330 [details] Pull request url Redirect review
Attachment #737330 - Flags: review?(timdream) → review?(felash)
leo+ as this is one of the blocking bugs from the QE1 test cycle.
blocking-b2g: leo? → leo+
Whiteboard: TD-8923 → TD-8923 [QE1]
Whiteboard: TD-8923 [QE1] → [TD-8923] [QE1]
Target Milestone: --- → Leo QE1 (5may)
Hi Julien, I have added a unit test for this. Please review again. Thanks! (In reply to Julien Wajsberg [:julienw] from comment #7) > Please add an unit test for this case. > > The update functionality has a quite comprehensive suite and I'd like to > keep it this way. > > Thanks !
Comment on attachment 737330 [details] Pull request url r=me thanks a lot !
Attachment #737330 - Flags: review?(felash) → review+
master: 671e2b3a0ac28c77930a795414df48c7d6690359
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Uplifted 671e2b3a0ac28c77930a795414df48c7d6690359 to: v1-train: 3774a756e70ec322d363b49d29fea43c5b214cff
status-b2g18: --- → fixed
Keywords: verifyme
QA Contact: jsmith
Verified on 4/18 build.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: