Randell Jesup [:jesup] (needinfo me) Assignee
	Description • 12 years ago

ThreadWrapper::GetThreadId() in the webrtc code imported from stable branch 3.20 returns a uint32_t; this causes a build failure on Mac builders due to warning about possible dataloss.

Patch bumps it to uint64_t to avoid platform-specific differences.

Needs to be fixed upstream

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 2 • 12 years ago

Use 1299 for webrtc.org:

http://code.google.com/p/webrtc/issues/detail?id=1299

	Eric Rescorla (:ekr)
	Comment 3 • 12 years ago

Comment on attachment 702441 [details] [diff] [review]
Fix GetThreadID return size (upstream bug)

Review of attachment 702441 [details] [diff] [review]:
-----------------------------------------------------------------

this is kinda gross, but I guess better than before

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 5 • 12 years ago

Comment on attachment 702635 [details] [diff] [review]
Fix GetThreadID return size (upstream bug)

carry r+=ekr forward

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 6 • 12 years ago

Will land with 3.20

	Timothy B. Terriberry (:derf)
	Comment 7 • 12 years ago

Fixed upstream in https://webrtc-codereview.appspot.com/1063005/,
though http://code.google.com/p/webrtc/issues/detail?id=1299 is still open.

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 8 • 12 years ago

import patch from Webrtc.org to avoid having to merge later

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 9 • 12 years ago

Comment on attachment 712195 [details] [diff] [review]
Thread intsize patch uplifted from webrtc.org

in-person r=derf

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 10 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/54960ffc951b

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/54960ffc951b