Closed
Bug 830908
Opened 12 years ago
Closed 12 years ago
Fix webrtc.org GetThreadID return size (upstream bug)
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Whiteboard: [WebRTC] [blocking-webrtc+] [qa-])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
ThreadWrapper::GetThreadId() in the webrtc code imported from stable branch 3.20 returns a uint32_t; this causes a build failure on Mac builders due to warning about possible dataloss. Patch bumps it to uint64_t to avoid platform-specific differences. Needs to be fixed upstream
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Depends on: webrtc_updates
Assignee | ||
Comment 2•12 years ago
|
||
Use 1299 for webrtc.org: http://code.google.com/p/webrtc/issues/detail?id=1299
Assignee | ||
Updated•12 years ago
|
Attachment #702441 -
Flags: review?(ekr)
Comment 3•12 years ago
|
||
Comment on attachment 702441 [details] [diff] [review] Fix GetThreadID return size (upstream bug) Review of attachment 702441 [details] [diff] [review]: ----------------------------------------------------------------- this is kinda gross, but I guess better than before
Attachment #702441 -
Flags: review?(ekr) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #702441 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → rjesup
Priority: -- → P1
Whiteboard: [WebRTC] [blocking-webrtc+]
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 702635 [details] [diff] [review] Fix GetThreadID return size (upstream bug) carry r+=ekr forward
Attachment #702635 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Attachment #702635 -
Flags: checkin?(rjesup)
Comment 7•12 years ago
|
||
Fixed upstream in https://webrtc-codereview.appspot.com/1063005/, though http://code.google.com/p/webrtc/issues/detail?id=1299 is still open.
Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 712195 [details] [diff] [review] Thread intsize patch uplifted from webrtc.org in-person r=derf
Attachment #712195 -
Flags: review+
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/54960ffc951b
Target Milestone: --- → mozilla21
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/54960ffc951b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc+] → [WebRTC] [blocking-webrtc+] [qa-]
Assignee | ||
Updated•12 years ago
|
Attachment #702635 -
Flags: checkin?(rjesup)
Assignee | ||
Updated•12 years ago
|
Attachment #702635 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•