Closed Bug 83119 Opened 23 years ago Closed 23 years ago

getComputedStyle() not supported for 'visibility'

Categories

(Core :: DOM: CSS Object Model, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla0.9.4

People

(Reporter: hsivonen, Assigned: harishd)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fix in hand])

Attachments

(3 files)

getComputedStyle(node, "").getPropertyValue("visibility") returns an empty string. Steps to reproduce: 1) Load the test case. Actual results: The comparison of visibility and an empty string evaluates to true. Expected results: Expected a string reflecting the actual property to be retuned. This bug blocks a complete implementation of bug 31961. (A partial implementation that just ignores visibility is possible, however.)
Harish, this would be a 5 or so line fix, right? Could you please look into this for mozilla0.9.2 (setting milestone for you).
Assignee: jst → harishd
Target Milestone: --- → mozilla0.9.2
Attached patch patch v1.1 (deleted) — Splinter Review
Status: NEW → ASSIGNED
Whiteboard: [fix in hand]
Does this patch still apply after hyatt's style code changes? If so, fix the indentation at: + const nsCString& visibility= + nsCSSProps::SearchKeywordTable(display->mVisible, + nsCSSProps::kVisibilityKTable); ^^^ and: + return val->QueryInterface(NS_GET_IID(nsIDOMCSSPrimitiveValue), + (void **)&aValue); ^^^^^ and you'll have sr=jst
moving to 0.9.3
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Attached patch patch v1.2 (deleted) — Splinter Review
sr=jst
Moving to more realistic target - m0.9.4!
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Priority: -- → P2
Fix landed on 08/07/01. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: