Closed
Bug 831291
Opened 12 years ago
Closed 12 years ago
GC: jsapi test Debugger fails under rooting analysis
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
I'm not sure about the use AutoArrayRooter in testIndirectEval. I couldn't find anything else to root an array of jsval though.
Attachment #702818 -
Flags: review?(wmccloskey)
Comment on attachment 702818 [details] [diff] [review]
Possible fix
Review of attachment 702818 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsapi-tests/testDebugger.cpp
@@ +160,5 @@
> }
>
> js::RootedObject debuggeeWrapper(cx, debuggee);
> CHECK(JS_WrapObject(cx, debuggeeWrapper.address()));
> + js::RootedValue v(cx, OBJECT_TO_JSVAL(debuggeeWrapper));
Can you replace OBJECT_TO_JSVAL with ObjectValue? It's just a little cleaner.
@@ +198,5 @@
> }
>
> js::RootedObject gWrapper(cx, g);
> CHECK(JS_WrapObject(cx, gWrapper.address()));
> + js::RootedValue v(cx, OBJECT_TO_JSVAL(gWrapper));
Same here.
Attachment #702818 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•