Closed
Bug 831407
Opened 12 years ago
Closed 12 years ago
test_399606.js has been replaced by browser_bug399606.js and should thus be removed from the tree
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: raymondlee, Assigned: raymondlee)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
If we do updatePlaces with uri: testURI, and then updatePlaces with uri: testURI and referrerURI: testURI, the second visit should not be added.
|
||
Comment 1•12 years ago
|
||
note: see bug 399606 for gory details
|
Assignee | |
Comment 2•12 years ago
|
||
Please also replace usage of AddURI with updatePlaces for test_399606.js when this bug is fixed. See the patch https://bugzilla.mozilla.org/attachment.cgi?id=702930
|
|
||
Comment 3•12 years ago
|
||
Actually, I just found this is instead fixed at
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/History.cpp#2225
that means VisitURI (invoked by the docshell) does the right thing, while updatePlaces, that is an API for sync and addon-ons, not for navigation, trusts the caller.
Since we have browser_bug399606.js covering the navigation part, I think we can just remove test_399606.js from the tree.
|
|
||
Comment 4•12 years ago
|
||
Raymond, do you have any time to do the removal patch?
Flags: needinfo?(raymond)
|
|
||
Updated•12 years ago
|
Summary: updatePlaces should not add a second visit if its referrer is the same site → test_399606.js has been replaced by browser_bug399606.js and should thus be removed from the tree
|
|
Assignee | |
Comment 5•12 years ago
|
||
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #704744 -
Flags: review?(mak77)
Flags: needinfo?(raymond)
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 704744 [details] [diff] [review]
v1
Review of attachment 704744 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks
Attachment #704744 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=de619bf94b6e
Attachment #704744 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 8•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 9•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•