Closed
Bug 831627
Opened 12 years ago
Closed 12 years ago
B2G STK: Support "Language Selection Event" Envelope command.
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: allstars.chh, Assigned: chucklee)
References
Details
Attachments
(4 files, 3 obsolete files)
|
(deleted),
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
See TS 101.223, clause 7.5.8 Language selection event
|
Reporter | |
Updated•12 years ago
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → chulee
|
|
Reporter | |
Comment 1•12 years ago
|
||
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #0)
> See TS 101.223, clause 7.5.8 Language selection event
Sorry, should be TS 102.223
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #706925 -
Flags: superreview?(jonas)
Attachment #706925 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #706926 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #706927 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Attachment #706928 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Add support event list in comment of sendStkEventDownload()
Attachment #706925 -
Attachment is obsolete: true
Attachment #706925 -
Flags: superreview?(jonas)
Attachment #706925 -
Flags: review?(allstars.chh)
Attachment #706930 -
Flags: superreview?(jonas)
Attachment #706930 -
Flags: review?(allstars.chh)
|
|
Reporter | |
Comment 7•12 years ago
|
||
Comment on attachment 706930 [details] [diff] [review]
0001. Add event object, v1.1
Review of attachment 706930 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/icc/interfaces/SimToolKit.idl
@@ +595,5 @@
> +dictionary MozStkLanguageSelectionEvent
> +{
> + /**
> + * The type of this event.
> + * It shall be nsIDOMMozIccManager.STK_EVENT_TYPE_LANGUAGE_SELECTION;
nit, ends with period.
@@ +602,5 @@
> +
> + /**
> + * Language Information
> + *
> + * @see ISO 639-1, Alpha-2 code
It would be great if we could put some examples here.
Attachment #706930 -
Flags: review?(allstars.chh) → review+
|
|
Reporter | |
Updated•12 years ago
|
Attachment #706926 -
Flags: review?(allstars.chh) → review+
|
|
Reporter | |
Updated•12 years ago
|
Attachment #706927 -
Flags: review?(allstars.chh) → review+
|
|
Reporter | |
Comment 8•12 years ago
|
||
Comment on attachment 706928 [details] [diff] [review]
0004. Test case for Event Download Command : Language Selection.
Review of attachment 706928 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +1569,5 @@
> + };
> + worker.RIL.sendStkEventDownload({
> + event: event
> + });
> +});
nit, add an extra line here.
Attachment #706928 -
Flags: review?(allstars.chh) → review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
Address comment 8
Attachment #706928 -
Attachment is obsolete: true
Attachment #706930 -
Flags: superreview?(jonas) → superreview+
|
|
Assignee | |
Comment 10•12 years ago
|
||
Address comment 7
Attachment #706930 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•12 years ago
|
||
Try server : https://tbpl.mozilla.org/?tree=Try&rev=4f967d3fba82
|
|
Reporter | |
Comment 12•12 years ago
|
||
|
||
Comment 13•12 years ago
|
||
These could use better commit messages (see comment 37 of bug 827280 for examples)
|
||
Comment 14•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f7eac60178f6
https://hg.mozilla.org/mozilla-central/rev/64b519b7fddf
https://hg.mozilla.org/mozilla-central/rev/ecede220333a
https://hg.mozilla.org/mozilla-central/rev/3125ccd01edb
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•