See TS 101.223, clause 7.5.6 Idle screen available event.

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #0) > See TS 101.223, clause 7.5.6 Idle screen available event. Sorry should be TS 102.223

Comment on attachment 705716 [details] [diff] [review] 0001. Add event object. Review of attachment 705716 [details] [diff] [review]: ----------------------------------------------------------------- Please also update comments in sendStkEventDownload nsIDOMIccManager.idl. sr? for Jonas for IDL change. ::: dom/icc/interfaces/SimToolKit.idl @@ +583,5 @@ > */ > DOMString language; > }; > + > +dictionary MozStkGeneralEvent{ nit, please move { to next line.

Comment on attachment 705721 [details] [diff] [review] 0004. Test case for Event Download Command : Idle Screen Available. Review of attachment 705721 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/tests/test_ril_worker_icc.js @@ +1517,5 @@ > +/** > + * Verify Event Download Command : Idle Screen Available > + */ > +add_test(function test_stk_event_download_idle_screen_available() { > + let worker = newUint8WithOutgoingIndexWorker(); I just realized this naming needs to be revised, at first I see 'WithOut' @@ +1537,5 @@ > + > + // BER length, TLV_DEVICE_ID_SIZE(4) + TLV_EVENT_LIST_SIZE(3) = 7 > + do_check_eq(pduHelper.readHexOctet(), 7); > + > + // Device Identifies, Type-Length-Value(Source ID-Destination ID) typo, Identities

Rename worker as comment 7. Also fix naming of a test function.

Update test case using new worker name

Comment on attachment 705716 [details] [diff] [review] 0001. Add event object. Review of attachment 705716 [details] [diff] [review]: ----------------------------------------------------------------- An alternative is to use inheritance. But I am okay either way.

Comment on attachment 705716 [details] [diff] [review] 0001. Add event object. Review of attachment 705716 [details] [diff] [review]: ----------------------------------------------------------------- Hi, Chuck Can you add sr=sicking for your IDL changed? thanks

Address comment 6 and add sr.

Try server : https://tbpl.mozilla.org/?tree=Try&rev=2c1a6c0dfb4b

https://hg.mozilla.org/integration/mozilla-inbound/rev/1183f031c783 https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b169983cdb https://hg.mozilla.org/integration/mozilla-inbound/rev/5f8b0e4a7e22 https://hg.mozilla.org/integration/mozilla-inbound/rev/f93346711a14 https://hg.mozilla.org/integration/mozilla-inbound/rev/5c0e27333599

https://hg.mozilla.org/mozilla-central/rev/1183f031c783 https://hg.mozilla.org/mozilla-central/rev/f3b169983cdb https://hg.mozilla.org/mozilla-central/rev/5f8b0e4a7e22 https://hg.mozilla.org/mozilla-central/rev/f93346711a14 https://hg.mozilla.org/mozilla-central/rev/5c0e27333599