Closed Bug 831757 Opened 12 years ago Closed 12 years ago

Click-to-play: Using history.pushState() makes plugin icon in the location bar vanish

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 verified, firefox-esr17- affected)

Status:
VERIFIED FIXED
Milestone:
mozilla21
Tracking Flags:
Tracking Status
firefox20 --- verified
firefox-esr17 - affected

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

(Whiteboard: [CtPUR:+] [CtPDefault:P2] fixed by bug 825804)

Attachments

(3 files, 1 obsolete file)

test case
(deleted), text/html
Details
Use LOCATION_CHANGE_SAME_DOCUMENT, v2
(deleted), patch
Details | Diff | Splinter Review
browser-chrome test
(deleted), patch
Details | Diff | Splinter Review
When using history.pushState(), the click-to-play plugin icon vanishes from the URL bar even though there still are embed/object elements. This affects e.g. SoundCloud which seems to have recently switched to using pushState.
Attached file test case (deleted) —
Attached patch Use LOCATION_CHANGE_SAME_DOCUMENT (obsolete) (deleted) — — Splinter Review
What SeaMonkey does looks cleaner to me and fixes this case.
I think bug 788584 was going to do this, but we never got around to it :-/
The change suggested by bug 788584 doesn't fix the vanishing icon, but i guess both could be fixed in one go.
Attachment #703445 - Attachment is obsolete: true
Attached patch browser-chrome test (deleted) — — Splinter Review
This still fails test 4 in browser_popupNotification.js, for which i don't know off-hand what's happing: https://tbpl.mozilla.org/?tree=Try&rev=8da1a4339b83
Assignee: nobody → georg.fritzsche
Whiteboard: [CtPUR:+]
Whiteboard: [CtPUR:+] → [CtPUR:+] [CtPDefault:P2]
Was this fixed by bug 825804?
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7) > Was this fixed by bug 825804? Yeah, should be fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
status-firefox20: --- → fixed
Depends on: 825804
Resolution: --- → FIXED
Whiteboard: [CtPUR:+] [CtPDefault:P2] → [CtPUR:+] [CtPDefault:P2] fixed by bug 825804
Target Milestone: --- → mozilla21
Verified fixed FF 20.0a2 (2013-02-18) Win 7
Status: RESOLVED → VERIFIED
status-firefox20: fixed → verified
We'll track bug 825804 for ESR.
tracking-firefox-esr17: ? → -
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: