Closed
Bug 831930
Opened 12 years ago
Closed 12 years ago
[Maps] The maps app contains redundant MP3 files for voice navigation
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gsvelto, Unassigned)
References
Details
After turning the maps app into a packaged application (see bug 829539) we noticed that it was taking a bit more space than expected (bug 821703). After inspecting the ZIP file we discovered that the app ships with voice navigation files in both the MP3 and OGG formats, presumably for compatibility with different browsers.
In order to save space we've modified the pre-packaged ZIP and removed the MP3 files (see https://github.com/mozilla-b2g/gaia/commit/5012a15288f1c393bcebf2fe2766b786d8097a6d). It would be better if the app could be packaged without the MP3 files in the first place if possible.
Thanks very much for taking care of this. We will now automate the creation of this package and make sure that only necessary assets will be delivered in next updates.
Just a reminder for Nokia: in the automated zip builds, the webapp manifest should also be changed: it should contain the geolocation permission and it should NOT contain the reference to the app-cache.
Comment 3•12 years ago
|
||
Not only the geolocation permission, but also the storage one.
That is, add :
"permissions" : {
"geolocation": { },
"storage": { }
}
All issues in this thread have now been solved in our build system. We can close this bug now. Thanks.
Comment 5•12 years ago
|
||
(In reply to AndyT from comment #4)
> All issues in this thread have now been solved in our build system. We can
> close this bug now. Thanks.
Good to see that this has been resolved on your end. However, don't we need a new updated packaged app file with this fix then to see it in FF OS?
No, we don't need a new packaged app file, because this was dealt with manually by Chris Jones for the current version. For all next updates, this will now automatically be taken care of. We can close this bug.
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•