Closed
Bug 831953
Opened 12 years ago
Closed 8 years ago
WiFi Tethering should use a unique Network Name (SSID)
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(tracking-b2g:backlog)
RESOLVED
WONTFIX
tracking-b2g | backlog |
People
(Reporter: st3fan, Assigned: hafid.traikzi)
References
Details
Attachments
(7 files)
(deleted),
text/x-github-pull-request
|
kaze
:
review+
|
Details |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Omega
:
ui-review-
|
Details |
(deleted),
application/pdf
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
text/x-github-pull-request
|
arthurcc
:
review+
|
Details |
(deleted),
text/x-github-pull-request
|
Details |
Using a unique network name prevents the bad guys from building 'rainbow tables' to speed up cracking WPA passwords. This is common practice for devices that use the same network name like 'linksys' or 'default'.
It would also lead to less confusion if two people in the same range use a FirefoxOS phone as a hotspot.
Ideally we simply add some unique text to the network name.
Reporter | ||
Updated•12 years ago
|
Blocks: b2gGaiaSecurity
Updated•11 years ago
|
Assignee: nobody → stephouillon
Comment 1•11 years ago
|
||
Attachment #8358799 -
Flags: review?(kaze)
Comment 2•11 years ago
|
||
Do you think it would make sense to change the SSID if we detect it’s set to `FirefoxHotSpot`? It would add a couple JS lines, but it would protect our ≤ 1.3 users when they update to 1.4.
Comment 3•11 years ago
|
||
Comment on attachment 8358799 [details]
https://github.com/mozilla-b2g/gaia/pull/15197
LGTM, but this patch raises a UX issue: the SSID name does not fit in the “Internet Sharing” panel any more. Please either fix this (with some UX help) and re-flag me, or open a follow-up and land it.
Attachment #8358799 -
Flags: review?(kaze) → review+
Updated•11 years ago
|
Flags: needinfo?(stephouillon)
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
I updated the PR with small changes to the UI. I changed the default name from "FirefoxHotpost_*****" to "FirefoxOS_*****" because a smaller name was needed and changed some CSS bits.
Attachment #8377056 -
Flags: ui-review?
Comment 7•11 years ago
|
||
It doesn't seem there is anyone being the ui-review? flag, any idea who I could ping?
Comment 8•11 years ago
|
||
Evelyn, I see you're module owner, could you tell me who I can ping to make things move for this bug?
Flags: needinfo?(ehung)
Comment 9•11 years ago
|
||
Comment on attachment 8377056 [details]
2.FirefoxOS_full.png
Hi Omega, can you take a look and provide some feedback? Thanks.
Attachment #8377056 -
Flags: ui-review? → ui-review?(ofeng)
Flags: needinfo?(ehung)
Comment 10•11 years ago
|
||
Comment on attachment 8377056 [details]
2.FirefoxOS_full.png
Please use list item with second line for Name and Security.
Attachment #8377056 -
Flags: ui-review?(ofeng) → ui-review-
Comment 11•11 years ago
|
||
Please use list item with second line for Name and Security.
Comment 12•11 years ago
|
||
Thx, I'll fix that;
Comment 13•10 years ago
|
||
Assignee | ||
Comment 14•10 years ago
|
||
Attachment #8576132 -
Flags: review?(josea.olivera)
Comment 15•10 years ago
|
||
Comment on attachment 8576132 [details]
https://github.com/mozilla-b2g/gaia/pull/28811
jaao suggested this should be reviewed by Arthur.
Attachment #8576132 -
Flags: review?(josea.olivera) → review?(arthur.chen)
Comment 16•10 years ago
|
||
Comment on attachment 8576132 [details]
https://github.com/mozilla-b2g/gaia/pull/28811
Good work! r=me with the comments addressed, thanks.
Attachment #8576132 -
Flags: review?(arthur.chen)
Updated•10 years ago
|
Attachment #8576132 -
Flags: review+
Updated•10 years ago
|
Assignee: stephouillon → hafid.traikzi
Assignee | ||
Comment 17•10 years ago
|
||
I have edited the patch to address your comments.
Thanks. :)
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 18•10 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#MfS2hEbMQbmBGy0BcHK70w
The pull request failed to pass integration tests. It could not be landed, please try again.
Assignee | ||
Comment 19•10 years ago
|
||
I updated my pull request... because my gaia's fork was not updated.
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 20•10 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#Ovn9y9dGS4KwZODjo8b9-A
The pull request failed to pass integration tests. It could not be landed, please try again.
Comment 21•10 years ago
|
||
Hafid, if you do not see something actionable from the test results (I say this, because I cannot see the error logs myself), you can re-trigger a test-run by either re-basing from master again or closing & reopening your pull request on GitHub.
Comment 22•10 years ago
|
||
Assignee | ||
Comment 23•10 years ago
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•